fix: show actual file path and caller location in FileHandle warnings#384
Draft
toddr-bot wants to merge 1 commit intocpan-authors:mainfrom
Draft
fix: show actual file path and caller location in FileHandle warnings#384toddr-bot wants to merge 1 commit intocpan-authors:mainfrom
toddr-bot wants to merge 1 commit intocpan-authors:mainfrom
Conversation
The PRINT method used literal '????' placeholders in its warning message,
and all tied handle methods (READLINE, GETC, EOF) pointed to FileHandle.pm
instead of the user's code. Now all methods use $self->{'file'} for the
path and caller() for the correct source location, matching real Perl's
warning format. Also adds the missing warning for PRINTF on read-only
handles.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replaces placeholder
????in tied FileHandle warning messages with actual file path and caller location.Why
When
printis called on a read-only mock handle, the warning was:This gives the user zero useful information. Real Perl says:
How
$self->{'file'}for the path andcaller()for the correct source location\nto prevent Perl from appending the FileHandle.pm locationprintfon read-only handles (real Perl warns, the mock was silent)Testing
🤖 Generated with Claude Code
Quality Report
Changes: 2 files changed, 24 insertions(+), 6 deletions(-)
Code scan: clean
Tests: failed (4 Failed, 94 test)
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline