Skip to content

glog: WITH_UNWIND=OFF ignored with 0.7.1, need to set none #844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NeroBurner merged 1 commit into from
May 7, 2026
Merged

glog: WITH_UNWIND=OFF ignored with 0.7.1, need to set none #844

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion cmake/projects/glog/hunter.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,12 +108,24 @@ hunter_add_version(
470e77edcaad491d2f676987ac5a2e739978dda5
)

if(HUNTER_glog_VERSION VERSION_GREATER_EQUAL 0.7.1)
set(_hunter_glog_with_unwind_off_flag "none")
else()
set(_hunter_glog_with_unwind_off_flag "OFF")
endif()
if(HUNTER_glog_VERSION VERSION_LESS 0.7.1)
# CMake 4.0+ compatibility with older Glog packages
set(_hunter_glog_cmake_compatibility_flag "CMAKE_POLICY_VERSION_MINIMUM=3.5")
else()
set(_hunter_glog_cmake_compatibility_flag "")
endif()
# explicitly remove dependency on gflags (only needed for tests)
hunter_cmake_args(glog CMAKE_ARGS
WITH_GFLAGS=OFF
WITH_UNWIND=OFF # since 0.5.0
WITH_UNWIND=${_hunter_glog_with_unwind_off_flag} # since 0.5.0
WITH_GTEST=OFF # since 0.6.0
BUILD_TESTING=OFF
${_hunter_glog_cmake_compatibility_flag}
)

hunter_pick_scheme(DEFAULT url_sha1_cmake)
Expand Down
Loading