Skip to content

Conversation

@mborland
Copy link
Member

Closes: #1299

@mborland mborland added this to the v6.0.0 milestone Jan 14, 2026
@mborland mborland self-assigned this Jan 14, 2026
@mborland mborland added the Bug Something isn't working label Jan 14, 2026
@codecov
Copy link

codecov bot commented Jan 14, 2026

Codecov Report

❌ Patch coverage is 97.67442% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.9%. Comparing base (322ffce) to head (ead1547).
⚠️ Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
test/github_issue_1299.cpp 97.0% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #1300     +/-   ##
=========================================
- Coverage     98.9%   98.9%   -0.0%     
=========================================
  Files          270     271      +1     
  Lines        17607   17683     +76     
  Branches      1883    1886      +3     
=========================================
+ Hits         17411   17486     +75     
- Misses         196     197      +1     
Files with missing lines Coverage Δ
include/boost/decimal/detail/cmath/fmax.hpp 100.0% <100.0%> (ø)
include/boost/decimal/detail/cmath/fmin.hpp 100.0% <100.0%> (+14.3%) ⬆️
include/boost/decimal/detail/cmath/nan.hpp 92.9% <100.0%> (+0.3%) ⬆️
test/github_issue_1299.cpp 97.0% <97.0%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 322ffce...ead1547. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mborland mborland merged commit a1f81d9 into develop Jan 14, 2026
77 checks passed
@mborland mborland deleted the 1299 branch January 14, 2026 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fmax and fmin handle snan improperly

2 participants