fix: use if/else instead of or helper for array bounds rendering#1174
Open
gennaroprota wants to merge 1 commit intocppalliance:developfrom
Open
fix: use if/else instead of or helper for array bounds rendering#1174gennaroprota wants to merge 1 commit intocppalliance:developfrom
gennaroprota wants to merge 1 commit intocppalliance:developfrom
Conversation
|
| Scope | Lines Δ% | Lines Δ | Lines + | Lines - | Files Δ | Files + | Files ~ | Files ↔ | Files - |
|---|---|---|---|---|---|---|---|---|---|
| 🛠️ Source | 100% | 2 | 1 | 1 | 1 | - | 1 | - | - |
| Total | 100% | 2 | 1 | 1 | 1 | - | 1 | - | - |
Legend: Files + (added), Files ~ (modified), Files ↔ (renamed), Files - (removed)
🔝 Top Files
- share/mrdocs/addons/generator/common/partials/type/declarator-suffix.hbs (Source): 2 lines Δ (+1 / -1)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1174 +/- ##
========================================
Coverage 82.12% 82.12%
========================================
Files 33 33
Lines 3149 3149
Branches 734 734
========================================
Hits 2586 2586
Misses 387 387
Partials 176 176
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
An automated preview of the documentation is available at https://1174.mrdocs.prtest2.cppalliance.org/index.html If more commits are pushed to the pull request, the docs will rebuild at the same URL. 2026-05-07 12:57:05 UTC |
The Handlebars `or` helper returns the boolean `false` when both
arguments are falsy, which renders as the literal text "false" inside
array brackets (e.g. `int arr[false]`). Replace
`{{or boundsValue boundsExpr}}` with an explicit `{{#if}}`/`{{else}}` so
that empty bounds render as `[]`.
gennaroprota
force-pushed
the
fix/rendering_of_arrays_with_unknown_bounds
branch
from
40cbaeb to
e0e18ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Handlebars
orhelper returns the booleanfalsewhen both arguments are falsy, which renders as the literal text "false" inside array brackets (e.g.int arr[false]). Replace{{or boundsValue boundsExpr}}with an explicit{{#if}}/{{else}}so that empty bounds render as[].