test: regression for the extract-all crash (issue #1195)#1198
Open
gennaroprota wants to merge 1 commit intocppalliance:developfrom
Open
test: regression for the extract-all crash (issue #1195)#1198gennaroprota wants to merge 1 commit intocppalliance:developfrom
gennaroprota wants to merge 1 commit intocppalliance:developfrom
Conversation
gennaroprota
force-pushed
the
fix/crash_when_extract_all_is_false
branch
from
9f91899 to
c9f0721
Compare
✨ Highlights
🧾 Changes by Scope
🔝 Top Files
|
`checkUndocumented` used to call `undocumented_.erase(it)` without first checking `it != end()`. Under `extract-all: false`, `undocumented_` never gets populated, so for any documented symbol `find()` returned `end()` and the unguarded erase was undefined behavior. A user reported this as a crash in v0.8.0. b103cba fixed this as part of an unrelated restructuring, but the existing fixture in this directory disabled `warn-if-undocumented` and so never reached the crashy block. The new fixture combines `extract-all: false` with the default `warn-if-undocumented: true` and includes a documented record. Closes issue cppalliance#1195.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1198 +/- ##
========================================
Coverage 82.12% 82.12%
========================================
Files 33 33
Lines 3149 3149
Branches 734 734
========================================
Hits 2586 2586
Misses 387 387
Partials 176 176
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gennaroprota
force-pushed
the
fix/crash_when_extract_all_is_false
branch
from
c9f0721 to
a1afdea
Compare
|
An automated preview of the documentation is available at https://1198.mrdocs.prtest2.cppalliance.org/index.html If more commits are pushed to the pull request, the docs will rebuild at the same URL. 2026-05-08 14:29:00 UTC |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
checkUndocumentedused to callundocumented_.erase(it)without first checkingit != end(). Underextract-all: false,undocumented_never gets populated, so for any documented symbolfind()returnedend()and the unguarded erase was undefined behavior. A user reported this as a crash in v0.8.0. b103cba fixed this as part of an unrelated restructuring, but the existing fixture in this directory disabledwarn-if-undocumentedand so never reached the crashy block. The new fixture combinesextract-all: falsewith the defaultwarn-if-undocumented: trueand includes a documented record.Closes issue #1195.