Introduce MeasureReference sealed interface#979
Merged
Conversation
|
Formatting check succeeded! |
JPercival
force-pushed
the
measure-reference
branch
2 times, most recently
from
9e6dfc0 to
74d1ea6
Compare
lukedegruchy
approved these changes
Mar 25, 2026
Contributor
lukedegruchy
left a comment
lukedegruchy
left a comment
There was a problem hiding this comment.
Approved with the caveat that it will require a lot of code to change downstream just to compile.
Replace Either3<CanonicalType, IdType, Measure> and the three-separate-lists
pattern (List<IdType>, List<String>, List<String>) with a single sealed type:
sealed interface MeasureReference {
record ById(IIdType id)
record ByIdentifier(String identifier)
record ByCanonicalUrl(String url)
}
HAPI providers convert at the boundary via fromOperationParams().
R4MeasureServiceUtils.getMeasures() dispatches on the sealed type.
R4CareGapsParameters uses List<MeasureReference> instead of 3 fields.
R4MultiMeasureService, R4CareGapsProcessor accept List<MeasureReference>.
R4CareGapsService.liftMeasureParameters() deleted -- boundary conversion
now happens once in the transport layer.
R4CollectDataService reads Measure directly via repository.read() instead
of wrapping in Either3.
The type is self-documenting: a measure can be referenced by ID,
identifier, or canonical URL. Compiler enforces exhaustive handling.
JPercival
force-pushed
the
measure-reference
branch
from
39d8d1a to
b866169
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace Either3<CanonicalType, IdType, Measure> and the three-separate-lists pattern (List, List, List) with a single sealed type:
sealed interface MeasureReference {
record ById(IIdType id)
record ByIdentifier(String identifier)
record ByCanonicalUrl(String url)
}
HAPI providers convert at the boundary via fromOperationParams(). R4MeasureServiceUtils.getMeasures() dispatches on the sealed type. R4CareGapsParameters uses List instead of 3 fields. R4MultiMeasureService, R4CareGapsProcessor accept List. R4CareGapsService.liftMeasureParameters() deleted -- boundary conversion now happens once in the transport layer.
R4CollectDataService reads Measure directly via repository.read() instead of wrapping in Either3.
The type is self-documenting: a measure can be referenced by ID, identifier, or canonical URL. Compiler enforces exhaustive handling.