Skip to content

changed tests for Integer vs Sting list compares#102

Open
bryantaustin13 wants to merge 1 commit into
cqframework:mainfrom
bryantaustin13:fixListIntegerVsString
Open

changed tests for Integer vs Sting list compares#102
bryantaustin13 wants to merge 1 commit into
cqframework:mainfrom
bryantaustin13:fixListIntegerVsString

Conversation

@bryantaustin13
Copy link
Copy Markdown
Contributor

This is a fix for cqframework/clinical_quality_language#1720 (comment) "Equivalence operation returning EvaluationError in several instances"

Added as List<Any> to expressions to clarify lists. Fixed the error that was occurring: "EvaluationError:Library expression-1.0.0 loaded, but had errors: Could not resolve call to operator Equivalent with signature (list<System.Integer>, list<System.String>)."

Changes those tests from fail to pass.

<test name="Equal123And123" version="1.0">
<capability code="list-operators" />
<expression>{ 1, 2, 3 } = { 1, 2, 3 }</expression>
<expression>{ 1, 2, 3 } as List&lt;Any&gt; = { 1, 2, 3 } as List&lt;Any&gt;</expression>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was frowning while reading the others, but this certainly would not need an as operator to be able to be evaluated?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Casting should not be necessary when the list on the left-hand side already has the same type signature as the list on the right-hand side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants