Fix image transforms ignoring focal points#145
Merged
Conversation
The fields() override called normalize(), which mutated the model by writing computed CF values (fit, gravity, etc.) onto $this. Since Yii's toArray() calls fields(), any serialization path (e.g. srcset via getUrlsBySize) would pre-fill gravity from position, blocking the focal point override in ImageTransformer. Remove fields()/normalize() and refactor toOptions() to compute derived values into the returned array without mutating the model. Fixes #144 Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #144
The
fields()override callednormalize(), which mutated the model by writing computed Cloudflare values (fit,gravity, etc.) onto$this. Since Yii'stoArray()callsfields(), any serialization path (e.g. srcset viagetUrlsBySize()) would pre-fillgravityfromposition, blocking the focal point override inImageTransformer.Gravity priority order
gravityon transform (e.g.gravity: 'face')ImageTransformerwhen no explicit gravity is setpositionfallback — computed bycomputeGravity()from Craft's position value