Skip to content

Add analyzer detecting double-wrapped Results.#19

Open
fkj wants to merge 1 commit intomasterfrom
add-double-wrapped-result-analyzer
Open

Add analyzer detecting double-wrapped Results.#19
fkj wants to merge 1 commit intomasterfrom
add-double-wrapped-result-analyzer

Conversation

@fkj
Copy link
Collaborator

@fkj fkj commented Mar 6, 2026

This detects a pattern that makes it easy to accidentally introduce subtle security bugs.

This detects a pattern that makes it easy to accidentally introduce
subtle security bugs.
@fkj fkj force-pushed the add-double-wrapped-result-analyzer branch from 34a4bc4 to 4ef0ddf Compare March 6, 2026 13:32
@fkj
Copy link
Collaborator Author

fkj commented Mar 6, 2026

Results of running on the Verify solution

4 occurrences detected, none of which were false positives. 3 of the occurrences were related to the same root cause definition.
Both of the root causes were real situations where error cases were "swallowed".

@fkj fkj marked this pull request as ready for review March 6, 2026 13:35
@fkj fkj requested a review from kasperhj March 6, 2026 13:35
Copy link

@kasperhj kasperhj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason for adding FsToolkit.ErrorHandling?

@fkj
Copy link
Collaborator Author

fkj commented Mar 9, 2026

What's the reason for adding FsToolkit.ErrorHandling?

It's used to compile the test programs when running tests.

@fkj fkj requested a review from kasperhj March 9, 2026 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants