Skip to content

Rename close hook as terminate hook #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremy-clerc merged 1 commit into from
Mar 4, 2026
Merged

Rename close hook as terminate hook #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/v1alpha1/applicationdisruptionbudget_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ type ApplicationDisruptionBudgetSpec struct {
// +kubebuilder:validation:Optional
HealthHook HookSpec `json:"healthHook,omitempty"`

// HookV2BasePath holds the base path for the prepare, ready, cancel hooks that will be
// HookV2BasePath holds the base path for the prepare, ready, terminate hooks that will be
// called at different stages of the NodeDisruption lifecycle.
// A POST http request containing a Disruption that is being reconciled is sent ot each of the hooks.
// +kubebuilder:validation:Optional
Expand Down
4 changes: 2 additions & 2 deletions app_manager_openapi.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,10 +128,10 @@ paths:
$ref: '#/responses/RetryAfter'
default:
$ref: '#/responses/UnexpectedError'
/close:
/terminate:
post:
summary: Notify the end of a disruption if the application needs to unprepare.
operationId: closeDisruption
operationId: terminateDisruption
tags:
- disruption
consumes:
Expand Down
2 changes: 1 addition & 1 deletion chart/templates/applicationdisruptionbudget-crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ spec:
type: object
hookV2BasePath:
description: |-
HookV2BasePath holds the base path for the prepare, ready, cancel hooks that will be
HookV2BasePath holds the base path for the prepare, ready, terminate hooks that will be
called at different stages of the NodeDisruption lifecycle.
A POST http request containing a Disruption that is being reconciled is sent ot each of the hooks.
properties:
Expand Down
2 changes: 1 addition & 1 deletion config/crd/bases/nodedisruption.criteo.com_applicationdisruptionbudgets.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ spec:
type: object
hookV2BasePath:
description: |-
HookV2BasePath holds the base path for the prepare, ready, cancel hooks that will be
HookV2BasePath holds the base path for the prepare, ready, terminate hooks that will be
called at different stages of the NodeDisruption lifecycle.
A POST http request containing a Disruption that is being reconciled is sent ot each of the hooks.
properties:
Expand Down
153 changes: 0 additions & 153 deletions internal/appmgrcli/disruption/close_disruption_parameters.go
View file
Open in desktop

This file was deleted.

172 changes: 0 additions & 172 deletions internal/appmgrcli/disruption/close_disruption_responses.go
View file
Open in desktop

This file was deleted.

Loading
Loading