Skip to content

feat: add addToTm parameter support for Add Translation API #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrii-bodnar merged 6 commits into from
Jan 31, 2025
Merged

feat: add addToTm parameter support for Add Translation API #197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d195025
feat: add addToTm parameter support for Add Translation API
imprvhub Jan 31, 2025
baa0ab5
feat: add addToTm parameter support for string translations
imprvhub Jan 31, 2025
d233e64
feat: add addToTm parameter to string translations
imprvhub Jan 31, 2025
76480e3
fix: remove duplicate add_translation method from translations resource
imprvhub Jan 31, 2025
dd6d66c
test(translations): fix test for upload_translation endpoint
imprvhub Jan 31, 2025
98cd347
refactor(string-translations): set addToTm default to None
imprvhub Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion crowdin_api/api_resources/string_translations/resource.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,14 +249,14 @@ def add_translation(
text: str,
projectId: Optional[int] = None,
pluralCategoryName: Optional[PluralCategoryName] = None,
addToTm: Optional[bool] = None,
):
"""
Add Translation.

Link to documentation:
https://developer.crowdin.com/api/v2/#operation/api.projects.translations.post
"""

projectId = projectId or self.get_project_id()

return self.requester.request(
Expand All @@ -267,6 +267,7 @@ def add_translation(
"languageId": languageId,
"text": text,
"pluralCategoryName": pluralCategoryName,
"addToTm": addToTm,
},
)

Expand Down
4 changes: 3 additions & 1 deletion crowdin_api/api_resources/string_translations/tests/test_string_translations_resources.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,6 +339,7 @@ def test_list_string_translations(self, m_request, in_params, request_params, ba
"languageId": "ua",
"text": "text",
"pluralCategoryName": None,
"addToTm": None,
},
),
(
Expand All @@ -353,6 +354,7 @@ def test_list_string_translations(self, m_request, in_params, request_params, ba
"languageId": "ua",
"text": "text",
"pluralCategoryName": "some name",
"addToTm": None,
},
),
),
Expand All @@ -362,7 +364,7 @@ def test_add_translation(self, m_request, in_params, request_data, base_absolut_
m_request.return_value = "response"

resource = self.get_resource(base_absolut_url)
assert resource.add_translation(projectId=1, **request_data) == "response"
assert resource.add_translation(projectId=1, **in_params) == "response"
m_request.assert_called_once_with(
method="post",
path=resource.get_translations_path(projectId=1),
Expand Down