fix: add branchIds parameter to apply_pre_translation #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
FaizaJibril
commented
Aug 26, 2025
FaizaJibril
commented
- Added branchIds: Optional[Iterable[int]] = None parameter
- Updated method signature and request data
- Added tests for the new parameter
- Resolved validation error when calling apply_pre_translation
- Fixed line length (E501)
- Removed trailing whitespace
- Fixed whitespace before parenthesis
…lation - Added branchIds: Optional[Iterable[int]] = None parameter - Updated method signature and request data - Added comprehensive tests for the new parameter - Maintains backward compatibility - Resolves validation error when calling apply_pre_translation Closes crowdin#211
- Added test for branchIds parameter handling - Added edge case tests for empty lists and parameter combinations - Improved test coverage from 47% to 98% - Tests would have caught the missing branchIds bug
- Fixed line length (E501) by breaking long import - Removed trailing whitespace (W293) - Fixed whitespace before parenthesis (E202) - All flake8 checks now pass
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #213 +/- ##
==========================================
+ Coverage 99.36% 99.36% +0.01%
==========================================
Files 178 178
Lines 8042 8066 +24
Branches 183 184 +1
==========================================
+ Hits 7990 8014 +24
Misses 37 37
Partials 15 15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andrii-bodnar
approved these changes
Aug 26, 2025
Member
andrii-bodnar
left a comment
andrii-bodnar
left a comment
There was a problem hiding this comment.
@FaizaJibril thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.