Warn user if imported key has derivation path different from xpub's depth

[roshii]

Fixes #397

[netlify]

✅ Deploy Preview for specter-desktop-docs canceled.

Name	Link
🔨 Latest commit	9f10871
🔍 Latest deploy log	https://app.netlify.com/projects/specter-desktop-docs/deploys/69133882eae2980008474973

[k9ert]

@stepansnigirev maybe you can have a look whether that PR goes in the right direction.

[roshii]

for the record: I marked it as draft since I want to ensure users are properly notified - so far it is only printing a line to the logs

[stepansnigirev]

Makes sense. We should notify about these inconsistencies at least in the logs. Warnings in the UI would be even better.

[roshii]

I did try to have this notification sent top UI but my frontend knowledge is pretty limited. Since I will not have enough time to investigate UI modification, I will leave it as is, with a simple warning in the logs.
Hope this helps.

[moneymanolis]

seems like there is off-by-one error, testing with this:

[8c24a510/84h/1h/0h]vpub5Y24kG7ZrCFRkRnHia2sdnt5N7MmsrNry1jMrP8XptMEcZZqkjQA6bc1f52RGiEoJmdy1Vk9Qck9tAL1ohKvuq3oFXe3ADVse6UiTHzuyKx

I've logged derivation_path out:

['m', '84h', '1h', '0h']

So this is where the mismatch comes from, it is counting the root whereas the depth of the xpub is counting from the root. @roshii wanna fix it?

Propagating the error to the UI is simple, just raise an Exception instead of the log statement (or in addition):

       raise Exception(
               f"xpup has a depth of {depth} while derivation path "
               f"indicates the key is {len(derivation_path)} levels deep"
           )

This code is taking the exceptions and their strings and propagates them to src/cryptoadvance/specter/server_endpoints/devices.py:

    @classmethod
    def parse_xpubs(cls, xpubs):
        xpubs = xpubs
        lines = [l.strip() for l in xpubs.split("\n") if len(l) > 0]
        failed = []
        keys = []
        for line in lines:
            try:
                keys.append(Key.parse_xpub(line))
            except Exception as e:
                failed.append(line + "\n" + str(e))
        return keys, failed
        

[roshii]

@moneymanolis should be addressed. thanks for the detailed review

[netlify]

✅ Deploy Preview for specter-desktop-docs canceled.

Name	Link
🔨 Latest commit	ff0b8cc
🔍 Latest deploy log	https://app.netlify.com/projects/specter-desktop-docs/deploys/6982277cc87c6100088e7b2e

[netlify]

✅ Deploy Preview for specter-desktop-docs canceled.

Name	Link
🔨 Latest commit	f4836cf
🔍 Latest deploy log	https://app.netlify.com/projects/specter-desktop-docs/deploys/69c4e1081df9d80008ee2f7b

both points addressed