add Keycard Shell support#2505
Merged
k9ert merged 4 commits intocryptoadvance:masterfrom Mar 26, 2026
Merged
Conversation
✅ Deploy Preview for specter-desktop-docs canceled.
|
✅ Deploy Preview for specter-desktop-docs canceled.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for the Keycard Shell hardware wallet, a QR-based signing device. The implementation follows established patterns in the codebase by inheriting from the Keystone device class and overriding specific properties to match Keycard Shell's capabilities.
Changes:
- Added KeycardShell device class that inherits from Keystone with appropriate property overrides
- Added Keycard Shell icon (SVG) for UI display
- Updated README to list Keycard Shell among supported hardware wallets
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/cryptoadvance/specter/devices/keycardshell.py | New device class implementing Keycard Shell support by inheriting from Keystone and overriding device capabilities |
| src/cryptoadvance/specter/devices/init.py | Added KeycardShell import and export to make the device available in the system |
| src/cryptoadvance/specter/static/img/devices/keycardshell_icon.svg | Added device icon for UI display |
| README.md | Updated documentation to include Keycard Shell in the list of supported hardware wallets |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
✅ Deploy Preview for specter-desktop-docs canceled.
|
Contributor
Author
|
anything we can do to get this merged? |
k9ert
force-pushed
the
add-keycard-shell
branch
from
1f6941c to
e434bb6
Compare
Contributor
|
This looks good. Sorry for the late reply. We're not picking up steam again ... |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
k9ert
force-pushed
the
add-keycard-shell
branch
from
dcb15d7 to
b138ce9
Compare
Contributor
|
Oh, i messed with your branch more or less the same minute you wanted to fix that. Sorry, for that. |
k9ert
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds support for the QR-based hardware wallet Keycard Shell. Interoperability has been tested on our end.