Conversation
align repository CI with other repos like cryptolib
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThis pull request consolidates and restructures the GitHub Actions CI/CD pipeline by integrating two separate publishing workflows into the main build workflow. The Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.github/workflows/build.yml (1)
91-99: Consider extracting deploy prechecks to a shared unit.Both deploy jobs duplicate the same tagged-version and
-SNAPSHOTvalidation logic. A reusable workflow/composite step would reduce drift and maintenance cost.Also applies to: 124-131
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/build.yml around lines 91 - 99, Extract the duplicated precheck steps ("Enforce to use tagged version" and "Verify project version is -SNAPSHOT") into a shared unit (either a reusable workflow or a composite action) and replace the inline blocks in both deploy jobs with a single call to that unit; move the logic that runs ./mvnw versions:set -DnewVersion="${GITHUB_REF##*/}" and the PROJECT_VERSION check (./mvnw help:evaluate and the test on "-SNAPSHOT") into the shared file, expose any needed inputs (e.g., GITHUB_REF) and outputs, and update both places that currently contain those steps to call the new reusable workflow/composite step (using uses: ./.github/workflows/<name>.yml or uses: ./github/actions/<name>) so the check is maintained in one place.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/build.yml:
- Around line 15-17: The permissions block for the GitHub Actions workflow is
missing the required "artifact-metadata: write" permission for
actions/attest@v4; update the permissions list in the workflow's permissions
block (the same block that contains "contents: read", "id-token: write", and
"attestations: write") to include "artifact-metadata: write" so the attestations
step can create the artifact storage record and succeed on tag builds.
---
Nitpick comments:
In @.github/workflows/build.yml:
- Around line 91-99: Extract the duplicated precheck steps ("Enforce to use
tagged version" and "Verify project version is -SNAPSHOT") into a shared unit
(either a reusable workflow or a composite action) and replace the inline blocks
in both deploy jobs with a single call to that unit; move the logic that runs
./mvnw versions:set -DnewVersion="${GITHUB_REF##*/}" and the PROJECT_VERSION
check (./mvnw help:evaluate and the test on "-SNAPSHOT") into the shared file,
expose any needed inputs (e.g., GITHUB_REF) and outputs, and update both places
that currently contain those steps to call the new reusable workflow/composite
step (using uses: ./.github/workflows/<name>.yml or uses:
./github/actions/<name>) so the check is maintained in one place.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: e5a45de1-f984-4d0a-ae8f-3b152b88cd44
📒 Files selected for processing (3)
.github/workflows/build.yml.github/workflows/publish-central.yml.github/workflows/publish-github.yml
💤 Files with no reviewable changes (2)
- .github/workflows/publish-central.yml
- .github/workflows/publish-github.yml
align repository CI with other repos like cryptolib