Open
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughAdds a new "Coming Soon" documentation category and index page; introduces new docs for Emergency Access and Files‑in‑Use; expands admin and vault‑management docs with Emergency Access event types, configuration, and UI workflows; replaces Keycloak‑centric user/group management docs with an in‑Hub admin UI workflow (users, groups, roles, avatars, enterprise notes); adds a CSS Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
🚥 Pre-merge checks | ❌ 3❌ Failed checks (1 warning, 2 inconclusive)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
src/pages/index.tsx (1)
18-22: Redundant wrapper<div>— the parent already centers inline-block childrenThe parent container has the
text--centerutility class (which setstext-align: center), so thedisplay: inline-blockpill will center itself without an extra block-level wrapper. The<div>adds no semantic value.♻️ Proposed simplification
- <div> - <Link to="/coming-soon" className={styles.announcementPill}> - ✨ Coming Soon → - </Link> - </div> + <Link to="/coming-soon" className={styles.announcementPill}> + ✨ Coming Soon → + </Link>🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/pages/index.tsx` around lines 18 - 22, Remove the redundant block-level wrapper around the announcement pill: instead of wrapping the Link (the element using className={styles.announcementPill}) in an extra <div>, render the Link directly as a child of the parent container that already has the text--center utility; this keeps the inline-block pill centered and removes the unnecessary DOM node while preserving the existing Link, its text ("✨ Coming Soon →") and the announcementPill class.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/hub/user-group-management.md`:
- Line 177: The sentence in the Hub docs contains a compound adjective that
needs suspended hyphenation; change "user and group related tasks" to "user- and
group-related tasks" in the sentence starting "You can access the Keycloak
management interface..." so the compound adjectives are correctly hyphenated.
- Around line 170-189: The release note's ":::info Enterprise Feature"
admonition is never closed and the ":::warning" was unintentionally nested;
close the enterprise info block immediately after its content by adding a
matching closing token (:::) right after the paragraph that ends with "Visit
[cryptomator.org](https://cryptomator.org/hub/) for more information about
Enterprise features.", then move the standalone ":::warning" admonition (the
paragraph about the `admin` and `syncer` accounts) outside and below that closed
info block so it applies globally; ensure you only use three-colon tokens
consistently (:::info ... ::: and :::warning ... :::) to properly open and close
each admonition.
In `@src/pages/index.module.css`:
- Around line 1-16: Add an explicit keyboard focus style and a smooth hover
transition to the .announcementPill to ensure accessible focus indication and
avoid abrupt hover changes: update the .announcementPill selector to include a
transition for background-color (and optionally color), and add a
.announcementPill:focus-visible rule that sets a clear, high-contrast outline or
box-shadow (and preserve border-radius) so keyboard users see a visible focus
ring; ensure :focus-visible only applies to the .announcementPill element and
does not rely on browser defaults.
---
Nitpick comments:
In `@src/pages/index.tsx`:
- Around line 18-22: Remove the redundant block-level wrapper around the
announcement pill: instead of wrapping the Link (the element using
className={styles.announcementPill}) in an extra <div>, render the Link directly
as a child of the parent container that already has the text--center utility;
this keeps the inline-block pill centered and removes the unnecessary DOM node
while preserving the existing Link, its text ("✨ Coming Soon →") and the
announcementPill class.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (7)
static/img/hub/group-add-member.pngis excluded by!**/*.pngstatic/img/hub/group-create.pngis excluded by!**/*.pngstatic/img/hub/group-detail.pngis excluded by!**/*.pngstatic/img/hub/group-list.pngis excluded by!**/*.pngstatic/img/hub/user-create.pngis excluded by!**/*.pngstatic/img/hub/user-detail.pngis excluded by!**/*.pngstatic/img/hub/user-list.pngis excluded by!**/*.png
📒 Files selected for processing (5)
docs/coming-soon/_category_.jsondocs/coming-soon/index.mddocs/hub/user-group-management.mdsrc/pages/index.module.csssrc/pages/index.tsx
Comment on lines
+1
to
+16
| .announcementPill { | ||
| display: inline-block; | ||
| padding: 0.4rem 1rem; | ||
| margin-bottom: 1rem; | ||
| border-radius: 2rem; | ||
| background-color: rgba(255, 255, 255, 0.15); | ||
| color: white; | ||
| font-size: 0.9rem; | ||
| text-decoration: none; | ||
| } | ||
|
|
||
| .announcementPill:hover { | ||
| background-color: rgba(255, 255, 255, 0.25); | ||
| color: white; | ||
| text-decoration: none; | ||
| } |
There was a problem hiding this comment.
Add a :focus-visible style for keyboard accessibility
There is no explicit focus indicator for the announcement pill. Docusaurus or the browser's default may be overridden or low-contrast against the primary hero background; adding an explicit outline ensures keyboard users always get a visible focus ring.
♿ Proposed addition
.announcementPill:hover {
background-color: rgba(255, 255, 255, 0.25);
color: white;
text-decoration: none;
}
+
+.announcementPill:focus-visible {
+ outline: 2px solid white;
+ outline-offset: 3px;
+}You may also want to add a transition for the hover background change to avoid the abrupt opacity jump:
.announcementPill {
display: inline-block;
padding: 0.4rem 1rem;
margin-bottom: 1rem;
border-radius: 2rem;
background-color: rgba(255, 255, 255, 0.15);
color: white;
font-size: 0.9rem;
text-decoration: none;
+ transition: background-color 0.2s ease;
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| .announcementPill { | |
| display: inline-block; | |
| padding: 0.4rem 1rem; | |
| margin-bottom: 1rem; | |
| border-radius: 2rem; | |
| background-color: rgba(255, 255, 255, 0.15); | |
| color: white; | |
| font-size: 0.9rem; | |
| text-decoration: none; | |
| } | |
| .announcementPill:hover { | |
| background-color: rgba(255, 255, 255, 0.25); | |
| color: white; | |
| text-decoration: none; | |
| } | |
| .announcementPill { | |
| display: inline-block; | |
| padding: 0.4rem 1rem; | |
| margin-bottom: 1rem; | |
| border-radius: 2rem; | |
| background-color: rgba(255, 255, 255, 0.15); | |
| color: white; | |
| font-size: 0.9rem; | |
| text-decoration: none; | |
| transition: background-color 0.2s ease; | |
| } | |
| .announcementPill:hover { | |
| background-color: rgba(255, 255, 255, 0.25); | |
| color: white; | |
| text-decoration: none; | |
| } | |
| .announcementPill:focus-visible { | |
| outline: 2px solid white; | |
| outline-offset: 3px; | |
| } |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@src/pages/index.module.css` around lines 1 - 16, Add an explicit keyboard
focus style and a smooth hover transition to the .announcementPill to ensure
accessible focus indication and avoid abrupt hover changes: update the
.announcementPill selector to include a transition for background-color (and
optionally color), and add a .announcementPill:focus-visible rule that sets a
clear, high-contrast outline or box-shadow (and preserve border-radius) so
keyboard users see a visible focus ring; ensure :focus-visible only applies to
the .announcementPill element and does not rely on browser defaults.
- add dedicated Emergency Access page - document Emergency Access settings and audit log events in Admin - extend Vault Management with setup/fix and creation flow details - add/update related Hub UI screenshots
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
docs/hub/vault-management.md (1)
28-34: Inconsistent admonition type — use:::info Early Accessto match the rest of the file.Elsewhere in this file (lines 55–57) and in
admin.md(lines 86–88) the standard pattern for early-access notices is:::info Early Access. This block uses:::notewith a plain-text qualifier instead, which produces a different visual style and is easy to overlook.✏️ Proposed fix
-:::note Emergency Access Status in Vault List (Enterprise only, early access) -In the `Vault List`, owners can see the Emergency Access status directly via badges: +:::info Early Access — Enterprise Only +Emergency Access is currently in **early access**. In the `Vault List`, owners can see the Emergency Access status directly via badges:🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/hub/vault-management.md` around lines 28 - 34, Replace the inconsistent admonition header ":::note Emergency Access Status in Vault List (Enterprise only, early access)" with the standard early-access admonition ":::info Early Access" so the block uses the same visual style as the other early-access notes; update the opening delimiter and ensure the closing "::: " remains in place to preserve the block content.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/hub/admin.md`:
- Line 154: Add the missing anchor ID to the "## Emergency Access" section by
updating the header line `## Emergency Access` to include the explicit markdown
anchor `{`#emergency-access`}` (so cross-links like `admin.md#emergency-access`
resolve correctly); locate the header text "## Emergency Access" in the file and
append the anchor immediately after it.
- Around line 153-175: Add an "Early Access" admonition to the admin Emergency
Access configuration section: locate the "Emergency Access" heading and the
block that mentions the Audit Log feature (the current ":::info Enterprise
Feature" block) and insert an ":::info Early Access" admonition (matching the
style used in the audit-log event subsection and in vault-management.md) near
the top of this section to indicate the feature is early access; ensure the
admonition text mirrors existing Early Access wording used elsewhere and does
not replace the existing Enterprise note.
In `@docs/hub/vault-management.md`:
- Around line 148-150: Add the missing Early Access admonition around the
"Setup/Fix Emergency Access Council" section (header "Setup/Fix Emergency Access
Council" or anchor {`#emergency-access-council`}) to match other Emergency Access
entries; wrap the paragraph that begins "To configure Emergency Access for a
vault..." in an :::info Early Access block so the section is consistent with the
other Emergency Access sections (e.g., the ones around lines 55–57).
---
Nitpick comments:
In `@docs/hub/vault-management.md`:
- Around line 28-34: Replace the inconsistent admonition header ":::note
Emergency Access Status in Vault List (Enterprise only, early access)" with the
standard early-access admonition ":::info Early Access" so the block uses the
same visual style as the other early-access notes; update the opening delimiter
and ensure the closing "::: " remains in place to preserve the block content.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (14)
static/img/hub/admin-emergency-access.pngis excluded by!**/*.pngstatic/img/hub/create-vault-download.pngis excluded by!**/*.pngstatic/img/hub/create-vault-emergency-access.pngis excluded by!**/*.pngstatic/img/hub/create-vault-recoverykey.pngis excluded by!**/*.pngstatic/img/hub/create-vault.pngis excluded by!**/*.pngstatic/img/hub/emergency_access_change_council_start.pngis excluded by!**/*.pngstatic/img/hub/emergency_access_change_permissions_start.pngis excluded by!**/*.pngstatic/img/hub/emergency_access_vault_list.pngis excluded by!**/*.pngstatic/img/hub/emergency_access_vault_list_change_council_abort_dialog.pngis excluded by!**/*.pngstatic/img/hub/emergency_access_vault_list_change_council_approve_dialog.pngis excluded by!**/*.pngstatic/img/hub/emergency_access_vault_list_change_council_approve_now.pngis excluded by!**/*.pngstatic/img/hub/emergency_access_vault_list_change_council_complete_dialog.pngis excluded by!**/*.pngstatic/img/hub/emergency_access_vault_list_change_council_complete_now.pngis excluded by!**/*.pngstatic/img/hub/emergency_access_vault_list_hover_process.pngis excluded by!**/*.png
📒 Files selected for processing (3)
docs/hub/admin.mddocs/hub/emergency-access.mddocs/hub/vault-management.md
✅ Files skipped from review due to trivial changes (1)
- docs/hub/emergency-access.md
infeo
commented
Mar 4, 2026
Make it easier to understand for less technical users
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
docs/hub/emergency-access.md (1)
71-73: Add terminal punctuation in note text.Line 72 should end with a period for consistency with the rest of the page.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/hub/emergency-access.md` around lines 71 - 73, Add a terminal period to the note sentence "When starting this process, the initiating user is automatically added to the new council" so it ends with a period; update the note block (the triple-colon :::note containing that exact sentence) to include the trailing "." for consistency with the page.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/hub/emergency-access.md`:
- Line 67: Update the sentence "The minimal required number of members are
configured in the [Admin settings](admin.md#emergency-access)." to use correct
word choice and subject-verb agreement; replace it with a grammatically correct
phrasing such as "The minimum required number of members is configured in the
[Admin settings](admin.md#emergency-access)." so the noun and verb agree and
"minimum" reads better than "minimal".
- Around line 90-97: The three bullet lines after "The popover shows:" are
top-level but should be nested; update the markdown so the items "process type
and required key shares", "current progress", "process council members", and
"per-member status (`Added` / `Pending`)" are indented as sub-bullets under the
"The popover shows:" line (e.g., indent each of those lines under the parent
bullet by four spaces) so they render as a nested list beneath that parent item.
---
Nitpick comments:
In `@docs/hub/emergency-access.md`:
- Around line 71-73: Add a terminal period to the note sentence "When starting
this process, the initiating user is automatically added to the new council" so
it ends with a period; update the note block (the triple-colon :::note
containing that exact sentence) to include the trailing "." for consistency with
the page.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: bb6490f5-8705-4f7c-906d-cd6e80b164ae
📒 Files selected for processing (1)
docs/hub/emergency-access.md
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (3)
docs/hub/admin.md (1)
156-158:⚠️ Potential issue | 🟡 MinorUse a concrete version here for consistency with the same page.
This section still says “upcoming release” while Line 87 already specifies
1.5.0. Use the same explicit version in both places.Suggested fix
:::info Early Access -This feature is currently in **early access** and will be fully available in an upcoming release. +This feature is currently in **early access** and will be fully available in version 1.5.0. :::🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/hub/admin.md` around lines 156 - 158, The ":::info Early Access" callout currently says "upcoming release" while the page uses concrete version 1.5.0 elsewhere; update the callout text inside the ":::info Early Access" block to reference the explicit version "1.5.0" (matching the mention at line 87) so both places use the same concrete version string.docs/hub/emergency-access.md (2)
63-63:⚠️ Potential issue | 🟡 MinorFix subject–verb agreement in the council-threshold sentence.
“The minimal required number of members are configured” is grammatically incorrect and reads awkwardly. Use “minimum … is configured”.
Suggested fix
-The minimal required number of members are configured in the [Admin settings](admin.md#emergency-access). +The minimum required number of members is configured in the [Admin settings](admin.md#emergency-access).🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/hub/emergency-access.md` at line 63, Replace the grammatically incorrect sentence "The minimal required number of members are configured in the [Admin settings](admin.md#emergency-access)." with a corrected version using singular agreement and clearer wording, e.g. "The minimum required number of members is configured in the [Admin settings](admin.md#emergency-access).", updating the line in docs/hub/emergency-access.md where that sentence appears.
87-92:⚠️ Potential issue | 🟡 MinorNest the popover detail bullets under the parent bullet.
The items under “The popover shows:” are currently top-level bullets instead of nested children.
Suggested fix
* The popover shows: - -* process type and required key shares -* current progress -* process council members -* per-member status (`Added` / `Pending`) + * process type and required key shares + * current progress + * process council members + * per-member status (`Added` / `Pending`)🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/hub/emergency-access.md` around lines 87 - 92, The bulleted list under the parent heading "The popover shows:" is not nested; change the four following bullets ("process type and required key shares", "current progress", "process council members", "per-member status (`Added` / `Pending`)") so they are child bullets of the parent bullet by indenting them (e.g., add two spaces or a tab before each line) so they render as nested items under "The popover shows:" in the markdown.
🧹 Nitpick comments (1)
docs/hub/vault-management.md (1)
55-57: Standardize Early Access release wording across docs.Both admonitions use “upcoming release”; elsewhere in this PR, Emergency Access already references
1.5.0. Consider using one consistent versioned message.Suggested fix
:::info Early Access -Emergency Access is currently in **early access** and will be fully available in an upcoming release. +Emergency Access is currently in **early access** and will be fully available in version 1.5.0. :::Also applies to: 150-152
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/hub/vault-management.md` around lines 55 - 57, The two Early Access admonitions use different wording; standardize them to reference the same versioned release (use "Emergency Access is currently in early access and will be fully available in v1.5.0.") Replace the current unversioned "upcoming release" text in the admonition beginning with ":::info Early Access" and the similar block at lines ~150-152 so both mention "v1.5.0" and match exact phrasing for consistency across docs.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/hub/vault-management.md`:
- Around line 31-33: The two docs use different labels for the same Emergency
Access state; choose one canonical label and make both files consistent — either
replace "Council missing" in docs/hub/vault-management.md with "No Vault Council
Member anymore" to match docs/hub/emergency-access.md, or update
docs/hub/emergency-access.md to use "Council missing"; ensure you update the
exact label string(s) and any references to that state so both pages use the
identical phrasing.
---
Duplicate comments:
In `@docs/hub/admin.md`:
- Around line 156-158: The ":::info Early Access" callout currently says
"upcoming release" while the page uses concrete version 1.5.0 elsewhere; update
the callout text inside the ":::info Early Access" block to reference the
explicit version "1.5.0" (matching the mention at line 87) so both places use
the same concrete version string.
In `@docs/hub/emergency-access.md`:
- Line 63: Replace the grammatically incorrect sentence "The minimal required
number of members are configured in the [Admin
settings](admin.md#emergency-access)." with a corrected version using singular
agreement and clearer wording, e.g. "The minimum required number of members is
configured in the [Admin settings](admin.md#emergency-access).", updating the
line in docs/hub/emergency-access.md where that sentence appears.
- Around line 87-92: The bulleted list under the parent heading "The popover
shows:" is not nested; change the four following bullets ("process type and
required key shares", "current progress", "process council members", "per-member
status (`Added` / `Pending`)") so they are child bullets of the parent bullet by
indenting them (e.g., add two spaces or a tab before each line) so they render
as nested items under "The popover shows:" in the markdown.
---
Nitpick comments:
In `@docs/hub/vault-management.md`:
- Around line 55-57: The two Early Access admonitions use different wording;
standardize them to reference the same versioned release (use "Emergency Access
is currently in early access and will be fully available in v1.5.0.") Replace
the current unversioned "upcoming release" text in the admonition beginning with
":::info Early Access" and the similar block at lines ~150-152 so both mention
"v1.5.0" and match exact phrasing for consistency across docs.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 1f4731e6-ba16-4d1e-967b-0908f6a08949
📒 Files selected for processing (3)
docs/hub/admin.mddocs/hub/emergency-access.mddocs/hub/vault-management.md
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* fix wrong description * replace "key shares" with "approval"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and "Coming soon" section.
Features to be included: