Skip to content

Return full list of adverse actions as top-level field #1512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
isabeleliassen merged 14 commits into from
May 4, 2026
Merged

Return full list of adverse actions as top-level field #1512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
99baa28
Return full list of adverse actions as top-level field
landonshumway-ia Apr 27, 2026
8ccbd39
Update API model to include AA field
landonshumway-ia Apr 27, 2026
6d08cb3
formatting
landonshumway-ia Apr 27, 2026
85f6d2f
update node dependencies for audit check
landonshumway-ia Apr 27, 2026
42d25d1
Update API spec to latest
landonshumway-ia Apr 28, 2026
f3399ce
Update node lambda dependencies
landonshumway-ia Apr 30, 2026
b07ec2d
Update compact-connect-ui lambda dependencies
landonshumway-ia Apr 30, 2026
8495eea
update compact-connect node lambda dependencies
landonshumway-ia Apr 30, 2026
ec7567b
update node lambda dependencies to pass audit check
landonshumway-ia Apr 30, 2026
efa9644
update GH action to account for authorize.net dependency
landonshumway-ia Apr 30, 2026
1d09861
update documentation for improved MFA recovery flow
landonshumway-ia Apr 30, 2026
791ef5b
update CDK requirements across projects
landonshumway-ia May 1, 2026
e76f7a8
update pip version in GH actions
landonshumway-ia May 1, 2026
408e60b
PR feedback - fix variable names
landonshumway-ia May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/check-common-cdk.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@ jobs:
# Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
- uses: actions/checkout@v5

- name: Upgrade pip
# Runner image ships pip 25.3; Upgrade to 26.1+ to include fix for CVE-2026-3219.
run: pip install --upgrade 'pip>=26.1'

- name: Install dev dependencies
run: "pip install -r backend/common-cdk/requirements-dev.in"

Expand All @@ -45,6 +49,10 @@ jobs:
with:
python-version: '3.14'

- name: Upgrade pip
# Runner image ships pip 25.3; Upgrade to 26.1+ to include fix for CVE-2026-3219.
run: pip install --upgrade 'pip>=26.1'

- name: Install dev dependencies
run: "pip install -r backend/common-cdk/requirements-dev.in"

Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/check-compact-connect-ui-app.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ jobs:
- uses: actions/checkout@v5

- name: Upgrade pip
# Runner image ships pip 25.3; upgrade to 26.0+ so pip-audit passes (CVE-2026-1703 fixed in 26.0)
run: pip install --upgrade 'pip>=26.0'
# Runner image ships pip 25.3; Upgrade to 26.1+ to include fix for CVE-2026-3219.
run: pip install --upgrade 'pip>=26.1'

- name: Install dev dependencies
run: "pip install -r backend/compact-connect-ui-app/requirements-dev.txt"
Expand Down Expand Up @@ -87,8 +87,8 @@ jobs:
python-version: '3.14'

- name: Upgrade pip
# Runner image ships pip 25.3; upgrade to 26.0+ so pip-audit passes (CVE-2026-1703 fixed in 26.0)
run: pip install --upgrade 'pip>=26.0'
# Runner image ships pip 25.3; Upgrade to 26.1+ to include fix for CVE-2026-3219.
run: pip install --upgrade 'pip>=26.1'

# Setup Node
- name: Setup Node
Expand Down
16 changes: 8 additions & 8 deletions .github/workflows/check-compact-connect.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ jobs:
- uses: actions/checkout@v5

- name: Upgrade pip
# Runner image ships pip 25.3; upgrade to 26.0+ so pip-audit passes (CVE-2026-1703 fixed in 26.0)
run: pip install --upgrade 'pip>=26.0'
# Runner image ships pip 25.3; Upgrade to 26.1+ to include fix for CVE-2026-3219.
run: pip install --upgrade 'pip>=26.1'

- name: Install dev dependencies
run: "pip install -r backend/compact-connect/requirements-dev.txt"
Expand Down Expand Up @@ -87,8 +87,8 @@ jobs:
python-version: '3.14'

- name: Upgrade pip
# Runner image ships pip 25.3; upgrade to 26.0+ so pip-audit passes (CVE-2026-1703 fixed in 26.0)
run: pip install --upgrade 'pip>=26.0'
# Runner image ships pip 25.3; Upgrade to 26.1+ to include fix for CVE-2026-3219.
run: pip install --upgrade 'pip>=26.1'

# Setup Node
- name: Setup Node
Expand Down Expand Up @@ -129,8 +129,8 @@ jobs:
python-version: '3.12'

- name: Upgrade pip
# Runner image ships pip 25.3; upgrade to 26.0+ so pip-audit passes (CVE-2026-1703 fixed in 26.0)
run: pip install --upgrade 'pip>=26.0'
# Runner image ships pip 25.3; Upgrade to 26.1+ to include fix for CVE-2026-3219.
run: pip install --upgrade 'pip>=26.1'

- name: Install dependencies
run: "cd backend/compact-connect/lambdas/python/purchases; pip install -r requirements.txt"
Expand All @@ -142,8 +142,8 @@ jobs:
run: "cd backend/compact-connect/lambdas/python/purchases; ruff check $(git ls-files '*.py')"

- name: Check Dependencies
# Ignore pip vulnerability that does not affect Python 3.12+
run: "pip-audit --ignore-vuln GHSA-4xh5-x5gv-qwph"
# Ignore known pip and lxml advisories currently accepted for this repo.
run: "pip-audit --ignore-vuln GHSA-4xh5-x5gv-qwph --ignore-vuln CVE-2026-41066"
Comment thread
landonshumway-ia marked this conversation as resolved.

- name: Test backend
run: "cd backend/compact-connect/lambdas/python/purchases; PYTHONPATH=../common pytest tests --cov --cov-fail-under=90"
8 changes: 4 additions & 4 deletions .github/workflows/check-cosmetology-app.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ jobs:
- uses: actions/checkout@v5

- name: Upgrade pip
# Runner image ships pip 25.3; upgrade to 26.0+ so pip-audit passes (CVE-2026-1703 fixed in 26.0)
run: pip install --upgrade 'pip>=26.0'
# Runner image ships pip 25.3; Upgrade to 26.1+ to include fix for CVE-2026-3219.
run: pip install --upgrade 'pip>=26.1'

- name: Install dev dependencies
run: "pip install -r backend/cosmetology-app/requirements-dev.txt"
Expand Down Expand Up @@ -86,8 +86,8 @@ jobs:
python-version: '3.14'

- name: Upgrade pip
# Runner image ships pip 25.3; upgrade to 26.0+ so pip-audit passes (CVE-2026-1703 fixed in 26.0)
run: pip install --upgrade 'pip>=26.0'
# Runner image ships pip 25.3; Upgrade to 26.1+ to include fix for CVE-2026-3219.
run: pip install --upgrade 'pip>=26.1'

# Setup Node
- name: Setup Node
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/check-multi-account.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ jobs:
- uses: actions/checkout@v2

- name: Upgrade pip
# Runner image ships pip 25.3; upgrade to 26.0+ so pip-audit passes (CVE-2026-1703 fixed in 26.0)
run: pip install --upgrade 'pip>=26.0'
# Runner image ships pip 25.3; Upgrade to 26.1+ to include fix for CVE-2026-3219.
run: pip install --upgrade 'pip>=26.1'

- name: Install dev dependencies
run: "pip install -r backend/multi-account/control-tower/requirements-dev.txt"
Expand All @@ -50,8 +50,8 @@ jobs:
python-version: '3.12'

- name: Upgrade pip
# Runner image ships pip 25.3; upgrade to 26.0+ so pip-audit passes (CVE-2026-1703 fixed in 26.0)
run: pip install --upgrade 'pip>=26.0'
# Runner image ships pip 25.3; Upgrade to 26.1+ to include fix for CVE-2026-3219.
run: pip install --upgrade 'pip>=26.1'

- name: Install dev dependencies
run: "pip install -r backend/multi-account/control-tower/requirements-dev.txt"
Expand Down
8 changes: 4 additions & 4 deletions backend/common-cdk/requirements.in
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
aws-cdk-lib>=2.142.0
aws-cdk-aws-lambda-python-alpha>=2.142.0a0
constructs>=10.0.0,<11.0.0
cdk-nag>=2.28.10, <3
aws-cdk-lib>=2.250.0
aws-cdk-aws-lambda-python-alpha>=2.250.0a0
constructs>=10.6.0,<11.0.0
cdk-nag>=2.37.55,<3
6 changes: 3 additions & 3 deletions backend/compact-connect-ui-app/lambdas/nodejs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,11 @@
"devDependencies": {
"aws-sdk-client-mock": "^4.1.0",
"aws-sdk-client-mock-jest": "^4.1.0",
"esbuild": "0.28.0",
"eslint": "^9.13.0",
"chai": "^4.1.2",
"chai-match-pattern": "^1.1.0",
"chalk": "^4.1.2",
"esbuild": "0.28.0",
"eslint": "10.2.1",
"lambda-local": "^2.2.0",
"mocha": "^11.7.5"
},
Expand All @@ -32,6 +32,6 @@
"zod": "^3.23.8"
},
"resolutions": {
"fast-xml-parser": "^5.5.7"
"fast-xml-parser": "5.7.0"
}
}
Loading
Loading