Frontend/cosmetology UI updates#1517
Merged
isabeleliassen merged 4 commits intocsg-org:mainfrom May 6, 2026
Merged
Conversation
Contributor
📝 WalkthroughWalkthroughComponents and pages were updated to be cosmetology-aware: UI text, conditional fields, permission options, and list/collection rendering now switch behavior or content when the app is in cosmetology mode. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@webroot/src/locales/en.json`:
- Line 544: The locale string for the key "licenseRegistrationEnabledSubtext" is
missing the reciprocal sentence and the phrase "in your state"; update the value
of licenseRegistrationEnabledSubtext in webroot/src/locales/en.json to the
agreed wording that includes the reciprocal sentence and the phrase "in your
state", preserving the existing HTML emphasis (<em>...</em>) and JSON string
quoting/commas so the file remains valid and consistent with other locale
entries.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 11c42585-500e-47e8-bfdf-6139aef820a7
📒 Files selected for processing (10)
webroot/src/components/Licensee/LicenseeList/LicenseeList.tswebroot/src/components/Licensee/LicenseeList/LicenseeList.vuewebroot/src/components/Licensee/LicenseeSearch/LicenseeSearch.tswebroot/src/components/Licensee/LicenseeSearch/LicenseeSearch.vuewebroot/src/components/Users/UserInvite/UserInvite.tswebroot/src/components/Users/UserRowEdit/UserRowEdit.tswebroot/src/locales/en.jsonwebroot/src/locales/es.jsonwebroot/src/pages/LicensingDetail/LicensingDetail.tswebroot/src/pages/LicensingDetail/LicensingDetail.vue
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
webroot/src/pages/PublicLicensingDetail/PublicLicensingDetail.vue (1)
49-53: ⚡ Quick winUse a stable key for each
LicenseCard.
LicenseCardowns local UI state, so:key="'license'+index"lets Vue reuse one card instance for a different license if this sorted list changes order after a refresh. Please key this list with a license identifier instead of the array index.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@webroot/src/pages/PublicLicensingDetail/PublicLicensingDetail.vue` around lines 49 - 53, The v-for list in PublicLicensingDetail.vue uses the array index as the key ("'license'+index"), which can cause LicenseCard components to be reused incorrectly; change the :key on the element rendering LicenseCard to use a stable license identifier from each item (e.g., license.id or license.licenseId) instead of the index so each LicenseCard instance is uniquely tied to its license in the licenseeLicenses array.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@webroot/src/pages/PublicLicensingDetail/PublicLicensingDetail.vue`:
- Around line 49-53: The v-for list in PublicLicensingDetail.vue uses the array
index as the key ("'license'+index"), which can cause LicenseCard components to
be reused incorrectly; change the :key on the element rendering LicenseCard to
use a stable license identifier from each item (e.g., license.id or
license.licenseId) instead of the index so each LicenseCard instance is uniquely
tied to its license in the licenseeLicenses array.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 852467ac-6dec-4e2f-b752-15f142ecb322
📒 Files selected for processing (10)
webroot/src/components/CompactSettingsConfig/CompactSettingsConfig.tswebroot/src/components/LicenseCard/LicenseCard.tswebroot/src/components/LicenseCard/LicenseCard.vuewebroot/src/components/StateSettingsConfig/StateSettingsConfig.tswebroot/src/locales/en.jsonwebroot/src/locales/es.jsonwebroot/src/pages/LicensingDetail/LicensingDetail.vuewebroot/src/pages/PublicLicensingDetail/PublicLicensingDetail.lesswebroot/src/pages/PublicLicensingDetail/PublicLicensingDetail.tswebroot/src/pages/PublicLicensingDetail/PublicLicensingDetail.vue
✅ Files skipped from review due to trivial changes (2)
- webroot/src/pages/LicensingDetail/LicensingDetail.vue
- webroot/src/components/LicenseCard/LicenseCard.ts
🚧 Files skipped from review as they are similar to previous changes (1)
- webroot/src/locales/en.json
rmolinares
approved these changes
May 4, 2026
Collaborator
Author
|
@jlkravitz This is ready for your review. |
jlkravitz
approved these changes
May 5, 2026
Collaborator
jlkravitz
left a comment
jlkravitz
left a comment
There was a problem hiding this comment.
@isabeleliassen Good to merge!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements List
Description List
Testing List
yarn test:unit:allshould run without errors or warningsyarn serveshould run without errors or warningsyarn buildshould run without errors or warningsCloses #1473
Closes #1472
Closes #1471
Closes #1475
Summary by CodeRabbit
New Features
Documentation