Skip to content

feat(additional-attributes): add test for "additional static attributes and remove old disabled tests#2

Open
HellButcher wants to merge 10 commits into
cstettler:mainfrom
HellButcher:main
Open

feat(additional-attributes): add test for "additional static attributes and remove old disabled tests#2
HellButcher wants to merge 10 commits into
cstettler:mainfrom
HellButcher:main

Conversation

@HellButcher
Copy link
Copy Markdown
Contributor

@HellButcher HellButcher commented Jan 12, 2026

  • removed disabled tests.
    replaced by new tests, that use the explicit pl:pass-additional-attributes attribute
  • pick correct fragment in file, and validate signature (required parameters inside ())
    (similar like th:insert and th:replace works)
  • set TemplateData to allow to correctly resolve relative templates (~{::fragment-name})
  • use seperate tag-processor for replacing slots.
    more roboust: only slots that survive evaluation (th:if) are replaced;

…es", and remove old disabled tests

## Template: https://www.conventionalcommits.org/
# <type>(optional scope): <description>
#
# [optional body]
#
# [optional footer(s)]
#
## type: fix feat test chore style revert refactor perf docs ci build
## footers: Refs BREAKING-CHANGE
##
@cstettler
Copy link
Copy Markdown
Owner

Hi @HellButcher, thank you very much for your valuable contributions! I will try to review and merge them as soon as possible. For the future, it would be easier to get smaller and more atomic pull requests (quickly describing the relevant what and how, as you already did). That would also allow faster review and faster merge. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants