feat(additional-attributes): add test for "additional static attributes and remove old disabled tests#2
Open
HellButcher wants to merge 10 commits into
Open
feat(additional-attributes): add test for "additional static attributes and remove old disabled tests#2HellButcher wants to merge 10 commits into
HellButcher wants to merge 10 commits into
Conversation
…es", and remove old disabled tests ## Template: https://www.conventionalcommits.org/ # <type>(optional scope): <description> # # [optional body] # # [optional footer(s)] # ## type: fix feat test chore style revert refactor perf docs ci build ## footers: Refs BREAKING-CHANGE ##
Owner
|
Hi @HellButcher, thank you very much for your valuable contributions! I will try to review and merge them as soon as possible. For the future, it would be easier to get smaller and more atomic pull requests (quickly describing the relevant what and how, as you already did). That would also allow faster review and faster merge. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replaced by new tests, that use the explicit
pl:pass-additional-attributesattribute())(similar like
th:insertandth:replaceworks)~{::fragment-name})more roboust: only slots that survive evaluation (
th:if) are replaced;