[Home/Search Screen UI] - Foundation: General Components, Icon Assets, Bottom Navigation Update, Constants #8
Conversation
…ts, icon assets, composeBom dependency update, bottom navigation update, minor design system updates
zachseidner1
left a comment
zachseidner1
left a comment
There was a problem hiding this comment.
Fantastic work! I love how you made the UI super flat which made this easy to review. I left a couple nits but great work as always.
| val name: String, @DrawableRes | ||
| val iconResId: Int |
There was a problem hiding this comment.
Nit: formatting is more clear as such:
data class ServiceCategory(
val name: String,
@DrawableRes val iconResId: Int
)Since it's more obvious that @DrawableRes is applied to the Int rather than the String
There was a problem hiding this comment.
whoops, seems like I missed it when I clicked reformat, will fix
| modifier: Modifier = Modifier | ||
| ) { | ||
| // TODO: Add loading and error states | ||
| SubcomposeAsyncImage( |
There was a problem hiding this comment.
Why SubcomposeAsyncImage over AsyncImage? Oh I see, I suppose you want custom loading and error states? I think that should be fine, if that's the case
There was a problem hiding this comment.
Yeah, it was mainly for the loading and error states in the future
| import com.cornellappdev.hustle.ui.theme.HustleTheme | ||
|
|
||
| @Composable | ||
| fun HustleButton( |
There was a problem hiding this comment.
The Slack Compose lint should be telling you that parameters are not in recommended order here, follow the lint please 🙏
There was a problem hiding this comment.
Yeah 😅, for some reason the lint was not being applied, but now it's working, so will fix!
| } | ||
|
|
||
| @Composable | ||
| fun ServiceCard( |
There was a problem hiding this comment.
Fix parameter order according to lint
There was a problem hiding this comment.
Same thing as above 😅 will fix
| } | ||
| } | ||
|
|
||
| data class ServiceCardPreviewParameters( |
| // Animate the button to scale up and then back to normal size | ||
| scale.animateTo(1.2f, spring(dampingRatio = Spring.DampingRatioMediumBouncy)) | ||
| scale.animateTo(1f, spring(dampingRatio = Spring.DampingRatioMediumBouncy)) |
There was a problem hiding this comment.
Awesome animation! but the comment is a little unnecessary lol
There was a problem hiding this comment.
ok, will remove!
Overview
Set up foundation for home/search screen ui with general components, icon assets, constants, etc.
https://www.figma.com/design/tRFDgfOFDXGXREx6q33p4P/Hustle?node-id=577-3679&t=ekSdFryK6xeB87PV-0
Changes Made
Test Coverage
Next Steps
Screenshots
Details
Screen.Recording.2025-11-16.at.1.21.47.AM.mov