Skip to content

Conversation

@vstarzf
Copy link
Contributor

@vstarzf vstarzf commented Mar 19, 2025

Overview

Adds a new report type to Resell and modifies the existing reporting UI.

Changes Made

  • Refactors reporting to support more than 2 report types
  • Adds new report type (post-transaction)
  • Adds new API/backend connection for the post-transaction reporting flow
  • Modifies existing UI to be closer to new reporting UI spec

Demo Video:

resell.test.reporting.mp4

Next Steps

Connect to PTF

…saction report) and bring reporting up to new UI spec
@vstarzf vstarzf self-assigned this Mar 19, 2025
@thisjustin123
Copy link
Contributor

Adds a new report type to Eatery

Resell you mean? :-)

Copy link
Contributor

@thisjustin123 thisjustin123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks pretty good to me! Do you have a demo of the new reporting stuff? Or can you not navigate to it yet?

Copy link
Contributor

@thisjustin123 thisjustin123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plz add a demo of the old reporting (front-end) flow working, since all of that was hooked up fine.

It's good to test this still since your old code might have unknowingly broken them, lol.

Copy link
Collaborator

@zachseidner1 zachseidner1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good on paper, but a bit confused as to why you opened a PR for this. In Next Steps you said that reporting is broken and you want to revisit this. So maybe this should just be a draft PR? Also as Justin requested, could you include a demo video of the changes? I think the PR we're looking for now then is the PTF.

@zachseidner1 zachseidner1 marked this pull request as draft April 9, 2025 19:09
@zachseidner1 zachseidner1 removed their request for review October 7, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants