refactor(backend-shared): fix getEnv return type inference#10598
Open
refactor(backend-shared): fix getEnv return type inference#10598
Conversation
Remove explicit `Record<string, (...args: any) => any>` annotation from `variables` and use `satisfies` to preserve inferred types. Change `getEnv` to use rest parameters so `ReturnType<Vars[T]>` resolves to actual types (boolean, string, number, etc.) instead of `any`.
waralexrom
approved these changes
Apr 1, 2026
waralexrom
approved these changes
Apr 1, 2026
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #10598 +/- ##
==========================================
- Coverage 57.89% 57.85% -0.05%
==========================================
Files 225 225
Lines 17587 17608 +21
Branches 3614 3621 +7
==========================================
+ Hits 10182 10187 +5
- Misses 6861 6877 +16
Partials 544 544
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove explicit
Record<string, (...args: any) => any>annotation fromvariablesand usesatisfiesto preserve inferred types. ChangegetEnvto use rest parameters soReturnType<Vars[T]>resolves to actual types (boolean, string, number, etc.) instead ofany.