fix: Fix potential NME when converting ParameterType to envelope

[mitchgrout]

Description

Sets source_reference to nil if the parameter type transformer does not provide a valid source location, i.e. is nil.

Fixes #1788

Type of change

Bug fix (non-breaking change which fixes an issue)

Checklist:

Your PR is ready for review once the following checklist is
complete. You can also add some checks if you want to.

• Tests have been added for any changes to behaviour of the code
• New and existing tests are passing locally and on CI
• bundle exec rubocop reports no offenses
• RDoc comments have been updated
• CHANGELOG.md has been updated

[mitchgrout]

@luke-hill relatively straight-forward fix, although I'm not super pleased with the rspec test due to the method of interest being private. I don't think this warrants an update to any of the features since it's an admittedly weird way to declare a ParameterType(), but I can add one if you think it's worth it

[luke-hill]

Not sure I agree on no source location being provided when a bound method. because it still exists there.

But I've not dug into it in more detail

Also we need to keep the contract up. I might ask how the other flavours deal with it

[luke-hill]

FYI I just encountered this at my job today. We used a lambda autofix from rubocop

[luke-hill]

Few style tweaks but other than that this is good to merge soon @mitchgrout

[luke-hill]

Note to self. Rebase with main (Should fix CCK issues), fix up CR style items and merge in

[luke-hill]

Hi @mitchgrout are you around and able to fix this? If not I'll try pick it up this month

[luke-hill]

Hi @mitchgrout can you rebase this and fix up the review points. It will make v11 (Which should be out in a month or less hopefully, if I can get the last bits of fixes for CCK in)

[luke-hill]

@mitchgrout thanks for this. Looks pretty good.

Next steps is you'll need to wait a short time (Probably a few days), until I merge a big PR into main.

At which point you'll need to rebase. And then CI should be fully green.

NB: At this point you'll need a fully green build - alongside rubocop compliance

[luke-hill]

@mitchgrout this is provisionally good.

Can you rebase / merge with latest main. At which point a CI run should be fully green.

Thankyou for your patience. I will endeavour to get this released soon in cucumber v11

[mitchgrout]

No problem - sorry for the delay on my side. I'm overseas for the next 2 days, so will update after then.

[mitchgrout]

Rebased and checked locally (Win10 setup w/ Ruby 3.2.2) - some seemingly expected failures in unrelated specs, but nothing that seems related to this change.

[luke-hill]

Thankyou for your patience. This will be released as part of v11 (Coming soon)