Open
Conversation
In RSpec 4.0, exposing the DSL globally will no longer be possible.
luke-hill
reviewed
Mar 27, 2026
Contributor
luke-hill
left a comment
luke-hill
left a comment
There was a problem hiding this comment.
Reviewed the simple stuff 61/64 are good. I'll review the other items soon.
luke-hill
reviewed
Mar 30, 2026
Contributor
luke-hill
left a comment
luke-hill
left a comment
There was a problem hiding this comment.
Reviewed all files. Couple of questions but by and large no issues
| c.before { Cucumber::Term::ANSIColor.coloring = true } | ||
| RSpec.configure do |config| | ||
| config.expose_dsl_globally = false | ||
| config.mock_with :rspec do |mocks| |
Contributor
There was a problem hiding this comment.
Is there a ref to what this does?
| end | ||
|
|
||
| context 'when mapping to world methods' do | ||
| let(:target) { double('target') } |
Contributor
There was a problem hiding this comment.
Given this just seems to be abstracting out a variable. I'm not sure why we need the three lines below? Are they needed?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This updates the spec suite to work with RSpec 4's default settings, meaning:
All this is in preparation for testing Cucumber with RSpec 4.0.0.beta1 in combination with diff-lcs 2.0. See #1814.
Type of change
Checklist:
Your PR is ready for review once the following checklist is
complete. You can also add some checks if you want to.
bundle exec rubocopreports no offenses