Implement card BIN functionality#29
Conversation
|
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughThis pull request extends bank name lookup to accept CLABE (18 digits) or card numbers (15–16 digits). It adds a CARD_BINS lookup table, updates TypeScript declarations, implements getBankName routing (ABM for CLABE, BIN for cards), adds getBankNameByBin and updates getBankNameOrThrow accordingly, expands tests for card/BIN paths and error cases, and bumps the package version. Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@test/test.js`:
- Line 21: The test constant VALID_CARD_BBVA is currently a Luhn-valid PAN
('4152314501669421'); change its value to a clearly synthetic PAN that preserves
the BIN prefix 415231 but cannot pass Luhn (e.g., replace the trailing digits
with zeros) so tests still validate BIN logic but do not use a real-looking card
number — update the constant named VALID_CARD_BBVA accordingly in test/test.js.
- Line 5: Remove the unused CARD_BINS import from the destructured import list
in test/test.js (CARD_BINS is causing ESLint no-unused-vars); locate the import
statement that includes CARD_BINS and delete that identifier, or alternatively
add a minimal smoke test that references CARD_BINS (e.g., asserting it is
defined) so the symbol is used — update the import or add the test accordingly
to satisfy the linter.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 20f3bd2f-383d-4ad5-ae5f-225665a646fb
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (4)
lib/card_bins.jslib/index.d.tslib/index.jstest/test.js
| const VALID_CLABE = '002000000000000008'; | ||
| const INVALID_CLABE_CONTROL_DIGIT = '002000000000000007'; | ||
| const INVALID_CLABE_BANK_CODE = '000000000000000000'; // Control digit es valido | ||
| const VALID_CARD_BBVA = '4152314501669421'; // BIN 415231 -> 40012 -> BBVA Mexico |
There was a problem hiding this comment.
Replace VALID_CARD_BBVA with a clearly synthetic PAN — the current value passes the Luhn check.
'4152314501669421' has a Luhn checksum of 0 (i.e., it is structurally valid as a real card number). Both OpenGrep and Microsoft Presidio flag it as a live PAN with high confidence. Since the tests only need the BIN prefix (415231) to be correct, replace the suffix with zeros to make it unambiguously synthetic:
-const VALID_CARD_BBVA = '4152314501669421'; // BIN 415231 -> 40012 -> BBVA Mexico
+const VALID_CARD_BBVA = '4152310000000000'; // BIN 415231 -> 40012 -> BBVA Mexico🧰 Tools
🪛 Microsoft Presidio Analyzer (2.2.362)
[high] 21-21: Detected payment card number with confidence 1.00. Remove the card number or use only payment-provider test PANs (e.g. 4242 4242 4242 4242).
(CREDIT_CARD)
🪛 OpenGrep (1.20.0)
[ERROR] 21-21: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@test/test.js` at line 21, The test constant VALID_CARD_BBVA is currently a
Luhn-valid PAN ('4152314501669421'); change its value to a clearly synthetic PAN
that preserves the BIN prefix 415231 but cannot pass Luhn (e.g., replace the
trailing digits with zeros) so tests still validate BIN logic but do not use a
real-looking card number — update the constant named VALID_CARD_BBVA accordingly
in test/test.js.
julietteceb16
force-pushed
the
feature/add-card-bins-lookup
branch
from
09b537f to
07db5cb
Compare
Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
♻️ Duplicate comments (1)
test/test.js (1)
20-20:⚠️ Potential issue | 🟠 Major | ⚡ Quick win
VALID_CARD_BBVAis still a Luhn-valid PAN — replace the suffix with zeros.
'4152314501669421'passes the Luhn check and is flagged with confidence 1.0 by two independent analyzers (OpenGrep + Microsoft Presidio). Since the BIN prefix415231is the only meaningful part for these tests, replace the account-specific digits with zeros to make it unambiguously synthetic.🐛 Proposed fix
-const VALID_CARD_BBVA = '4152314501669421'; // BIN 415231 -> 40012 -> BBVA Mexico +const VALID_CARD_BBVA = '4152310000000000'; // BIN 415231 -> 40012 -> BBVA Mexico🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@test/test.js` at line 20, Replace the Luhn-valid PAN string in VALID_CARD_BBVA so the test uses a synthetic, non-Luhn account portion: update the constant VALID_CARD_BBVA (currently '4152314501669421') to keep the BIN prefix '415231' and set the remaining account digits to zeros (e.g., '4152310000000000' or similar length-preserving zero suffix) so analyzers no longer flag it as a real card number.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Duplicate comments:
In `@test/test.js`:
- Line 20: Replace the Luhn-valid PAN string in VALID_CARD_BBVA so the test uses
a synthetic, non-Luhn account portion: update the constant VALID_CARD_BBVA
(currently '4152314501669421') to keep the BIN prefix '415231' and set the
remaining account digits to zeros (e.g., '4152310000000000' or similar
length-preserving zero suffix) so analyzers no longer flag it as a real card
number.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: a1667a73-68d5-4a2f-a262-d1d5101ff0d8
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (4)
lib/card_bins.jslib/index.d.tslib/index.jstest/test.js
✅ Files skipped from review due to trivial changes (1)
- lib/card_bins.js
1 participant
Summary by CodeRabbit
New Features
Tests
Chores