Update cuenca-validations to version 2.1.31.dev0, increment internal …#440
Update cuenca-validations to version 2.1.31.dev0, increment internal …#440rcabrera-py wants to merge 1 commit intomainfrom
Conversation
…version to 2.1.20.dev0, and add PasswordReset resource with tests.
WalkthroughThis PR introduces a new PasswordReset resource to the cuenca Python package. It adds a PasswordReset class to Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@cuenca/http/client.py`:
- Line 21: SANDBOX_HOST is incorrectly set to the same value as API_HOST so
configure(sandbox=True) doesn't switch environments; restore a distinct sandbox
hostname by changing the SANDBOX_HOST assignment (symbol SANDBOX_HOST in
cuenca/http/client.py) back to the sandbox-specific host used by the service and
ensure configure(sandbox=True) uses SANDBOX_HOST instead of API_HOST (refer to
the configure(sandbox=True) logic and any host-selection code that reads
API_HOST/SANDBOX_HOST).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: f579c9db-d1a0-4fa8-a059-4ca9028b44df
📒 Files selected for processing (7)
cuenca/__init__.pycuenca/http/client.pycuenca/resources/__init__.pycuenca/resources/password_resets.pycuenca/version.pyrequirements.txttests/resources/test_password_resets.py
|
|
||
| API_HOST = 'api.cuenca.com' | ||
| SANDBOX_HOST = 'sandbox.cuenca.com' | ||
| SANDBOX_HOST = 'api.cuenca.com' |
There was a problem hiding this comment.
Restore a distinct sandbox host for sandbox mode.
Line 21 makes SANDBOX_HOST equal to API_HOST, so configure(sandbox=True) no longer changes environment. This collapses sandbox/prod separation and matches the observed 403 failures in password reset tests.
🔧 Proposed fix
API_HOST = 'api.cuenca.com'
-SANDBOX_HOST = 'api.cuenca.com'
+SANDBOX_HOST = 'sandbox.cuenca.com'🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@cuenca/http/client.py` at line 21, SANDBOX_HOST is incorrectly set to the
same value as API_HOST so configure(sandbox=True) doesn't switch environments;
restore a distinct sandbox hostname by changing the SANDBOX_HOST assignment
(symbol SANDBOX_HOST in cuenca/http/client.py) back to the sandbox-specific host
used by the service and ensure configure(sandbox=True) uses SANDBOX_HOST instead
of API_HOST (refer to the configure(sandbox=True) logic and any host-selection
code that reads API_HOST/SANDBOX_HOST).
…version to 2.1.20.dev0, and add PasswordReset resource with tests.
Summary by CodeRabbit
New Features
Chores