FOLIOSYNC-12: Combine downloading and syncing logic + add tests#44
Merged
wtomaszewska merged 11 commits intomainfrom Mar 23, 2026
Merged
Conversation
…and syncing logic
…acinth records; add tests for HyacinthSynchronizer class
…ne-downloading-and-syncing-logic
…yncer) and Title parsing method
…ne-downloading-and-syncing-logic
elohanlon
requested changes
Mar 21, 2026
Member
elohanlon
left a comment
elohanlon
left a comment
There was a problem hiding this comment.
Great updates, thank you! I have just one requested change, which I left in a separate comment.
wtomaszewska
deleted the
feature/FOLIOSYNC-12-combine-downloading-and-syncing-logic
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket FOLIOSYNC-12
This PR extracts FOLIO-to-Hyacinth syncing logic from the rake task into dedicated classes:
HyacinthRecordWriterto assemble and sync records to FOLIO