Added option to toggle deployment of admin pod and related services#114
Open
Hagsterr wants to merge 5 commits intocurityio:masterfrom
Open
Added option to toggle deployment of admin pod and related services#114Hagsterr wants to merge 5 commits intocurityio:masterfrom
Hagsterr wants to merge 5 commits intocurityio:masterfrom
Conversation
…if admin is disabled.
…ed when curity.admin.enabled=false
Author
|
I am a bit unsure what to add to the README.md and what "convention" I should follow and put "ignored if curity.admin.enabled=true". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In production environments where you only use the runtime of Curity the deployment of admin is unneccessary. It could also conflict with policy engines where if you don't maintain and regulate the admin pod(even if you dont use it) you get policy violations.
I was informed by Daniel that the alarms function might not work because thats handled by the admin pod, but in environments where you use external tools to monitor the health and events of Curity this is a redundant feature and is not affected by disabling the admin pod.
Default deployment set to true because of the norm.
Appreciate any feedback :D 🕺