IS-11347 Unify completed-with-success and completed-with-error handling#196
Draft
aleixsuau wants to merge 1 commit into
Draft
Conversation
Merges both terminal OAuth response steps under a single `handleCompletedStep` with one config knob: `autoRedirectOnAuthenticationComplete`. Default `true` (auto-redirect both); accepts `false`, `'ONLY_ON_SUCCESS'`, `'ONLY_ON_ERROR'` for finer control. Replaces `redirectOnAuthenticationCompletedWithSuccess`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: https://curity.atlassian.net/browse/IS-11347
Summary
Unifies
completed-with-successandcompleted-with-errorHAAPI step handling under a singlehandleCompletedStepwith one config knob —autoRedirectOnAuthenticationComplete. Previously the LWA auto-redirected on success but exposed errors asnextStepData, even though both server-side step shapes carry anauthorization-responselink and the Velocity-rendered UI auto-redirects in both cases.Config
autoRedirectOnAuthenticationComplete: boolean | AUTO_REDIRECT_ON_AUTHENTICATION_COMPLETE(defaulttrue).true→ redirect on both success and errorfalse→ expose the completed step asnextStepDatafor both'ONLY_ON_SUCCESS'→ redirect on success, expose on error'ONLY_ON_ERROR'→ redirect on error, expose on successBreaking rename of
redirectOnAuthenticationCompletedWithSuccess— safe because the LWA is still pre-1.0 and has no external consumers.Test plan
completed-with-error(e.g. unknownclient_id) auto-redirects under default configautoRedirectOnAuthenticationComplete: 'ONLY_ON_SUCCESS'causes the error step to surface asnextStepData