IS-9422: adds template to evaluate browser context needed for BankID …#39
Open
IS-9422: adds template to evaluate browser context needed for BankID …#39
Conversation
phylexm
approved these changes
Dec 22, 2025
daniellindau
approved these changes
Dec 22, 2025
pmhsfelix
force-pushed
the
feature/main/IS-9422-bankid-send-returnUrl-in-background
branch
from
6727d8f to
ebb0829
Compare
…returnURL computation on the backend
pmhsfelix
force-pushed
the
feature/main/IS-9422-bankid-send-returnUrl-in-background
branch
from
ebb0829 to
9c19da6
Compare
There was a problem hiding this comment.
Pull request overview
Adds a new BankID Velocity template intended to collect basic browser context (touch capability) and then redirect back to the same URL so the authenticator flow can continue with that context available.
Changes:
- Added a
compute-browser-context.vmredirect template for the BankID “enter personal number” step. - Captures
navigator.maxTouchPointsinto anmtpquery parameter via a hidden form field. - Adds a
ctx=1marker parameter to ensure a non-empty query string on the redirect.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| document.getElementById("nmtp").setAttribute("value", "" + nmtp) | ||
| </script> | ||
|
|
||
| ## just to ensure the query-string is not empty and we do not endup on an infinit loop |
There was a problem hiding this comment.
Typo in comment: "endup" should be "end up".
Suggested change
| ## just to ensure the query-string is not empty and we do not endup on an infinit loop | |
| ## just to ensure the query-string is not empty and we do not end up on an infinit loop |
| document.getElementById("nmtp").setAttribute("value", "" + nmtp) | ||
| </script> | ||
|
|
||
| ## just to ensure the query-string is not empty and we do not endup on an infinit loop |
There was a problem hiding this comment.
Typo in comment: "infinit" should be "infinite".
Suggested change
| ## just to ensure the query-string is not empty and we do not endup on an infinit loop | |
| ## just to ensure the query-string is not empty and we do not endup on an infinite loop |
phylexm
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds template to evaluate browser context needed for BankID.