IS-10950 reading listing template from env-var, previever script impr.#57
Open
IS-10950 reading listing template from env-var, previever script impr.#57
Conversation
…ace delete button with descriptive text when those lists contain only one item and MFA is using respective authentication methods
There was a problem hiding this comment.
Pull request overview
Enables selecting the Identity Server preview “listing template” via the LISTING_TEMPLATE environment variable.
Changes:
- Update
previewer.jsto append-l <LISTING_TEMPLATE>to the Java process args when the env var is set. - Replace string throws with
Errorinstances for required argument validation. - Align
package-lock.jsonworkspaces with the current repo layout (removes non-existentsrc/login-web-appentry).
Reviewed changes
Copilot reviewed 1 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/identity-server/previewer.js |
Adds env-var-driven listing template argument and improves error throwing style. |
package-lock.json |
Updates workspace list to match the repository’s existing workspaces. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/identity-server/previewer.js
Outdated
|
|
||
| if (process.env.LISTING_TEMPLATE) { | ||
| procArgs.push('-l'); | ||
| procArgs.push(process.env.LISTING_TEMPLATE) |
There was a problem hiding this comment.
Avoid automated semicolon insertion (92% of all statements in the enclosing function have an explicit semicolon).
Contributor
Author
There was a problem hiding this comment.
@copilot open a new pull request to apply changes based on this feedback
luisgoncalves
approved these changes
Jan 27, 2026
| procArgs.push(optionsOrArgv['additional-static-root']) | ||
| } | ||
|
|
||
| if (process.env.LISTING_TEMPLATE) { |
Contributor
There was a problem hiding this comment.
I'm not familiar with this script, but would it make sense to pass this via optionsOrArgv, as with other things above?
Contributor
Author
There was a problem hiding this comment.
That would require to change all npm scripts to allow setting this param and because it's intended just for an internal use I think the env. var. is better approach here.
urre
approved these changes
Jan 28, 2026
…ing-last-mfa-used-device [IS-10866] removing device may lockout the user
Add repo badges
…ui-js IS-11067 Improve curity-ui.js
- react-router ^7.9.4 → ^7.13.1 (fixes CSRF, XSS, open redirect CVEs) - vite ^7.1.12 → ^7.3.1 (fixes rollup path traversal CVE) - cypress ^15.5.0 → ^15.11.0 (fixes systeminformation command injection CVEs) - npm audit fix for transitive deps (qs, lodash, immutable via relay-compiler) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…emes-to-be-watched IS-10358 Allow custom themes to be watched
…endencies-due-to-vulnerabilities IS-11041: Update SSP dependencies to fix npm audit vulnerabilities
…t-after-urls-ready IS-10358 Fix toast not going away after dev urls are ready
…ector-for-submit-buttons-without-proper-variants IS-11076 Simplify submit button CSS selector and fix outline button c…
Bumps [@babel/runtime](https://github.com/babel/babel/tree/HEAD/packages/babel-runtime) from 7.22.5 to 7.28.6. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.28.6/packages/babel-runtime) --- updated-dependencies: - dependency-name: "@babel/runtime" dependency-version: 7.28.6 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.21 to 4.17.23. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.21...4.17.23) --- updated-dependencies: - dependency-name: lodash dependency-version: 4.17.23 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [mdast-util-to-hast](https://github.com/syntax-tree/mdast-util-to-hast) from 13.2.0 to 13.2.1. - [Release notes](https://github.com/syntax-tree/mdast-util-to-hast/releases) - [Commits](syntax-tree/mdast-util-to-hast@13.2.0...13.2.1) --- updated-dependencies: - dependency-name: mdast-util-to-hast dependency-version: 13.2.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [diff](https://github.com/kpdecker/jsdiff) from 5.2.0 to 5.2.2. - [Changelog](https://github.com/kpdecker/jsdiff/blob/master/release-notes.md) - [Commits](kpdecker/jsdiff@v5.2.0...v5.2.2) --- updated-dependencies: - dependency-name: diff dependency-version: 5.2.2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [h3](https://github.com/h3js/h3) from 1.15.4 to 1.15.6. - [Release notes](https://github.com/h3js/h3/releases) - [Changelog](https://github.com/h3js/h3/blob/v1.15.6/CHANGELOG.md) - [Commits](h3js/h3@v1.15.4...v1.15.6) --- updated-dependencies: - dependency-name: h3 dependency-version: 1.15.6 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…on/css/docs/h3-1.15.6 Bump h3 from 1.15.4 to 1.15.6 in /src/common/css/docs
…on/css/docs/mdast-util-to-hast-13.2.1 Bump mdast-util-to-hast from 13.2.0 to 13.2.1 in /src/common/css/docs
…on/css/docs/diff-5.2.2 Bump diff from 5.2.0 to 5.2.2 in /src/common/css/docs
Bumps [svgo](https://github.com/svg/svgo) from 4.0.0 to 4.0.1. - [Release notes](https://github.com/svg/svgo/releases) - [Commits](svg/svgo@v4.0.0...v4.0.1) --- updated-dependencies: - dependency-name: svgo dependency-version: 4.0.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…on/css/docs/svgo-4.0.1 Bump svgo from 4.0.0 to 4.0.1 in /src/common/css/docs
…dix-ui-react-dialog replace unmaintained @reach/dialog with @radix-ui/react-dialog
* Factorize BankID authenticator polling logic Version 2 in shared fragments * Use polling logic Version 2 in BankID signing authenticator, based on a feature flag (bankidConsentorLaunchVersion2). Old polling logic remains the default one.
…e that we should install dependencies from monorepo root
…entor-update-polling-logic IS-10603 Use updated polling logic for BankID signing consentor.
fix npm audit issues for all ui-kit projects
…e that we should install dependencies from monorepo root
# Conflicts: # package-lock.json
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Merge/11 1/dev/2026 03 18
Merge/11 1/dev/2026 03 19
…and-image IS-10358 Update README hero image to support dark mode
…vel-watch-mode-for-component-library IS-10358 Update component-library use watch mode from root level npm start
Co-authored-by: markoweb <2862929+markoweb@users.noreply.github.com>
Co-authored-by: markoweb <2862929+markoweb@users.noreply.github.com>
markoweb
force-pushed
the
IS-10950-previewer-listing
branch
from
396902f to
e6f841c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is allowing to change the listing template by setting the
LISTING_TEMPLATEenv var.