Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Identity Server previewer startup script to allow the listing page template to be overridden (so it can be edited locally), and aligns workspace metadata in the lockfile.
Changes:
- Add support for passing a listing template path to the Java previewer via
LISTING_TEMPLATE(-larg). - Replace string throws with
Errorobjects and clean up a few JS style issues (const/semicolons). - Update
package-lock.jsonworkspaces list to removesrc/login-web-app.
Reviewed changes
Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/identity-server/previewer.js |
Adds listing-template support and refactors error handling / minor cleanup. |
package-lock.json |
Updates workspace list to match the current monorepo layout. |
Comments suppressed due to low confidence (1)
src/identity-server/previewer.js:220
prepareSettingsalways assignsconfig['additional-static-root'](line 219) even when the option isn't provided, which creates the property with anundefinedvalue. Later,watch()uses theinoperator to decide whether to watch the additional root, so this can cause it to start watching paths likeundefined/**/**.css. Only setconfig['additional-static-root']when the option is actually defined (or adjust the downstream check to test the value rather than property presence).
config['static-root'] = optionsOrArgv['static-root'];
config['template-root'] = optionsOrArgv['template-root'];
config['message-root'] = optionsOrArgv['message-root'];
config['additional-static-root'] = optionsOrArgv['additional-static-root'];
return config;
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: markoweb <2862929+markoweb@users.noreply.github.com>
Co-authored-by: markoweb <2862929+markoweb@users.noreply.github.com>
396902f to
e6f841c
Compare
urre
approved these changes
Mar 23, 2026
Collaborator
|
We created a page in confluence on how to work with the template listing page: https://curity.atlassian.net/wiki/pages/resumedraft.action?draftId=463601666&draftShareId=e71341ca-e9e4-485f-aeb2-bfcd1e55d46d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the previewer's listing page available for editing.