Skip to content

IS-10950 previewer listing#96

Open
markoweb wants to merge 4 commits intodevfrom
IS-10950-previewer-listing
Open

IS-10950 previewer listing#96
markoweb wants to merge 4 commits intodevfrom
IS-10950-previewer-listing

Conversation

@markoweb
Copy link
Copy Markdown
Contributor

Makes the previewer's listing page available for editing.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Identity Server previewer startup script to allow the listing page template to be overridden (so it can be edited locally), and aligns workspace metadata in the lockfile.

Changes:

  • Add support for passing a listing template path to the Java previewer via LISTING_TEMPLATE (-l arg).
  • Replace string throws with Error objects and clean up a few JS style issues (const/semicolons).
  • Update package-lock.json workspaces list to remove src/login-web-app.

Reviewed changes

Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.

File Description
src/identity-server/previewer.js Adds listing-template support and refactors error handling / minor cleanup.
package-lock.json Updates workspace list to match the current monorepo layout.
Comments suppressed due to low confidence (1)

src/identity-server/previewer.js:220

  • prepareSettings always assigns config['additional-static-root'] (line 219) even when the option isn't provided, which creates the property with an undefined value. Later, watch() uses the in operator to decide whether to watch the additional root, so this can cause it to start watching paths like undefined/**/**.css. Only set config['additional-static-root'] when the option is actually defined (or adjust the downstream check to test the value rather than property presence).
    config['static-root'] = optionsOrArgv['static-root'];
    config['template-root'] = optionsOrArgv['template-root'];
    config['message-root'] = optionsOrArgv['message-root'];
    config['additional-static-root'] = optionsOrArgv['additional-static-root'];
    return config;

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Matus Marko and others added 4 commits March 23, 2026 13:54
Co-authored-by: markoweb <2862929+markoweb@users.noreply.github.com>
Co-authored-by: markoweb <2862929+markoweb@users.noreply.github.com>
@markoweb markoweb force-pushed the IS-10950-previewer-listing branch from 396902f to e6f841c Compare March 23, 2026 11:55
@urre
Copy link
Copy Markdown
Collaborator

urre commented Mar 23, 2026

We created a page in confluence on how to work with the template listing page: https://curity.atlassian.net/wiki/pages/resumedraft.action?draftId=463601666&draftShareId=e71341ca-e9e4-485f-aeb2-bfcd1e55d46d

@markoweb markoweb self-assigned this Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants