Replace chai.assert with node:assert/strict

.oxlintrc.json

@@ -39,6 +39,12 @@
     "eslint/no-restricted-imports": [
       "warn",
       {
+        "paths": [
+          {
+            "name": "node:assert",
+            "message": "Use node:assert/strict instead"
+          }
+        ],
         "patterns": [
           {
             "group": ["../*/src", "../*/src/*", "../../*/src", "../../*/src/*"],
@@ -77,6 +83,7 @@
     "typescript/restrict-template-expressions": "off",
     "typescript/unbound-method": "off",
     "unicorn/prefer-module": "warn",
+    "unicorn/prefer-node-protocol": "warn",
     "unicorn/throw-new-error": "warn"
   },
   "overrides": [

packages/app-vscode/src/createVscodeIde.ts

@@ -1,4 +1,4 @@
-import * as crypto from "crypto";
+import * as crypto from "node:crypto";
 import * as os from "node:os";
 import * as path from "node:path";
 import type { ExtensionContext } from "vscode";

packages/app-vscode/src/ide/vscode/textLine.vscode.test.ts

@@ -1,4 +1,4 @@
-import * as assert from "assert";
+import * as assert from "node:assert/strict";
 import { getReusableEditor } from "@cursorless/lib-vscode-common";
 import VscodeTextLine from "./VscodeTextLine";
 

packages/app-vscode/src/keyboard/buildSuffixTrie.test.ts

@@ -1,4 +1,4 @@
-import assert from "node:assert";
+import * as assert from "node:assert/strict";
 import type { KeyValuePair } from "./buildSuffixTrie";
 import { buildSuffixTrie } from "./buildSuffixTrie";
 import { isEqual, sortBy, uniq, uniqWith } from "lodash-es";
@@ -130,8 +130,8 @@ suite("buildSuffixTrie", () => {
         sortEntries(chars.flatMap((char) => trie.search(char))),
         isEqual,
       ).map(({ key, value }) => ({ key, value }));
-      assert.deepStrictEqual(actual, sortEntries(expected));
-      assert.deepStrictEqual(
+      assert.deepEqual(actual, sortEntries(expected));
+      assert.deepEqual(
         sortBy(conflicts.map(sortEntries), (conflict) =>
           JSON.stringify(conflict),
         ),

packages/app-vscode/src/keyboard/grammar/getAcceptableTokenTypes.test.ts

@@ -1,4 +1,4 @@
-import assert from "assert";
+import * as assert from "node:assert/strict";
 import nearley from "nearley";
 import type { KeyDescriptor } from "../TokenTypeHelpers";
 import grammar from "./generated/grammar";
@@ -153,7 +153,7 @@ suite("keyboard.getAcceptableTokenTypes", () => {
             arg: value.partialArg,
           },
         };
-        assert(
+        assert.ok(
           candidates.some((result) => isEqual(result, fullValue)),
           "Relevant candidates (note that symbols will be missing):\n" +
             JSON.stringify(candidates, null, 2),

packages/app-vscode/src/keyboard/grammar/grammar.test.ts

@@ -1,6 +1,6 @@
 import nearley from "nearley";
 import grammar from "./generated/grammar";
-import assert from "assert";
+import * as assert from "node:assert/strict";
 import type { KeyDescriptor } from "../TokenTypeHelpers";
 import type { KeyboardCommandHandler } from "../KeyboardCommandHandler";
 import type { KeyboardCommand } from "../KeyboardCommandTypeHelpers";
@@ -189,7 +189,7 @@ suite("keyboard grammar", () => {
       parser.feed(tokens);
 
       assert.equal(parser.results.length, 1);
-      assert.deepStrictEqual(parser.results[0], expected);
+      assert.deepEqual(parser.results[0], expected);
     });
   });
 });

packages/app-vscode/src/scripts/initLaunchSandbox.ts

@@ -4,7 +4,7 @@
  * developing the Cursorless VSCode extension locally.
  */
 import { extensionDependencies } from "@cursorless/lib-common";
-import * as cp from "child_process";
+import * as cp from "node:child_process";
 
 const vsCodeToolName: string = "code";
 const validCliToolParams: Array<string> = ["--code", "--codium"];

packages/app-vscode/src/scripts/populateDist/runCommand.ts

@@ -1,5 +1,5 @@
-import { exec } from "child_process";
-import { promisify } from "util";
+import { exec } from "node:child_process";
+import { promisify } from "node:util";
 
 const execAsync = promisify(exec);
 

packages/app-web-docs/docusaurus.config.mts

@@ -2,7 +2,7 @@ import type { Config } from "@docusaurus/types";
 import type { Root } from "mdast";
 import { createRequire } from "node:module";
 import { fileURLToPath } from "node:url";
-import { dirname, extname, relative, resolve } from "path";
+import { dirname, extname, relative, resolve } from "node:path";
 import { themes } from "prism-react-renderer";
 import type { Transformer } from "unified";
 import { visit } from "unist-util-visit";

packages/app-web-docs/src/docs/components/flattenHighlights.test.ts

@@ -1,5 +1,5 @@
 import { BorderStyle, Range } from "@cursorless/lib-common";
-import * as assert from "node:assert";
+import * as assert from "node:assert/strict";
 import { flattenHighlights } from "./flattenHighlights";
 import type { Highlight, Scope } from "./types";
 

packages/lib-common/src/ide/inMemoryTextEditor/test/InMemoryTextDocument.test.ts

@@ -1,4 +1,4 @@
-import * as assert from "node:assert";
+import * as assert from "node:assert/strict";
 import { URI } from "vscode-uri";
 import { Position } from "../../../types/Position";
 import { Range } from "../../../types/Range";
@@ -73,7 +73,7 @@ suite("InMemoryTextDocument", () => {
   test("positionAt", () => {
     const document = createTestDocument("hello  \n  world\r\n");
 
-    assert.equal(document.positionAt(-1), "0:0");
+    assert.equal(document.positionAt(-1).toString(), "0:0");
     assert.equal(document.positionAt(0).toString(), "0:0");
     assert.equal(document.positionAt(6).toString(), "0:6");
     assert.equal(document.positionAt(7).toString(), "0:7");

packages/lib-common/src/ide/inMemoryTextEditor/test/InMemoryTextDocumentEdit.test.ts

@@ -1,4 +1,4 @@
-import * as assert from "node:assert";
+import * as assert from "node:assert/strict";
 import { Range } from "../../../types/Range";
 import { createTestDocument } from "./createTestDocument";
 

packages/lib-common/src/ide/inMemoryTextEditor/test/InMemoryTextDocumentLineAt.test.ts

@@ -1,5 +1,5 @@
 import { range } from "lodash-es";
-import * as assert from "node:assert";
+import * as assert from "node:assert/strict";
 import { createTestDocument } from "./createTestDocument";
 
 interface TestCaseFixture {

packages/lib-common/src/scopeVisualizerUtil/generateDecorationsForCharacterRange/handleMultipleLines.test.ts

@@ -1,4 +1,4 @@
-import assert from "assert";
+import * as assert from "node:assert/strict";
 import { map } from "itertools";
 import { Range } from "../../types/Range";
 import { BorderStyle } from "../decorationStyle.types";
@@ -136,7 +136,7 @@ suite("handleMultipleLines", () => {
         ],
       );
 
-      assert.deepStrictEqual(actual, testCase.expected);
+      assert.deepEqual(actual, testCase.expected);
     });
   }
 });

packages/lib-common/src/testUtil/serialize.ts

@@ -10,7 +10,7 @@ class CustomDump {
     private readonly opts: yaml.DumpOptions,
   ) {}
 
-  represent() {
+  represent(): string {
     let result = yaml.dump(
       this.data,
       Object.assign({ replacer, schema }, this.opts),
@@ -35,7 +35,7 @@ const schema = yaml.DEFAULT_SCHEMA.extend({ implicit: [customDumpType] });
 const isObject = (value: unknown): value is object =>
   typeof value === "object" && value != null;
 
-function hasSimpleChildren(value: unknown) {
+function hasSimpleChildren(value: unknown): boolean {
   if (isObject(value)) {
     return Object.values(value).every(
       (value) => !isObject(value) && !Array.isArray(value),
@@ -44,9 +44,10 @@ function hasSimpleChildren(value: unknown) {
   if (Array.isArray(value)) {
     return value.every((value) => !isObject(value) && !Array.isArray(value));
   }
+  return false;
 }
 
-function replacer(key: string, value: unknown) {
+function replacer(key: string, value: unknown): unknown {
   if (key === "") {
     return value;
   } // top-level, don't change this
@@ -58,6 +59,9 @@ function replacer(key: string, value: unknown) {
   return value; // default
 }
 
-export const serialize = (obj: unknown) =>
-  new CustomDump(obj, { noRefs: true, quotingType: '"' }).represent().trim() +
-  "\n";
+export function serialize(obj: unknown): string {
+  return (
+    new CustomDump(obj, { noRefs: true, quotingType: '"' }).represent().trim() +
+    "\n"
+  );
+}

packages/lib-common/src/types/generalizedRangeContains.test.ts

@@ -1,10 +1,10 @@
-import assert from "assert";
+import * as assert from "node:assert/strict";
 import { generalizedRangeContains } from "./GeneralizedRange";
 import { Position } from "./Position";
 
 suite("generalizedRangeContains", () => {
   test("character", () => {
-    assert.strictEqual(
+    assert.equal(
       generalizedRangeContains(
         {
           type: "character",
@@ -19,7 +19,7 @@ suite("generalizedRangeContains", () => {
       ),
       true,
     );
-    assert.strictEqual(
+    assert.equal(
       generalizedRangeContains(
         {
           type: "character",
@@ -34,7 +34,7 @@ suite("generalizedRangeContains", () => {
       ),
       true,
     );
-    assert.strictEqual(
+    assert.equal(
       generalizedRangeContains(
         {
           type: "character",
@@ -52,7 +52,7 @@ suite("generalizedRangeContains", () => {
   });
 
   test("line", () => {
-    assert.strictEqual(
+    assert.equal(
       generalizedRangeContains(
         {
           type: "line",
@@ -67,7 +67,7 @@ suite("generalizedRangeContains", () => {
       ),
       true,
     );
-    assert.strictEqual(
+    assert.equal(
       generalizedRangeContains(
         {
           type: "line",
@@ -82,7 +82,7 @@ suite("generalizedRangeContains", () => {
       ),
       true,
     );
-    assert.strictEqual(
+    assert.equal(
       generalizedRangeContains(
         {
           type: "line",
@@ -100,7 +100,7 @@ suite("generalizedRangeContains", () => {
   });
 
   test("mixed", () => {
-    assert.strictEqual(
+    assert.equal(
       generalizedRangeContains(
         {
           type: "line",
@@ -115,7 +115,7 @@ suite("generalizedRangeContains", () => {
       ),
       true,
     );
-    assert.strictEqual(
+    assert.equal(
       generalizedRangeContains(
         {
           type: "line",
@@ -130,7 +130,7 @@ suite("generalizedRangeContains", () => {
       ),
       false,
     );
-    assert.strictEqual(
+    assert.equal(
       generalizedRangeContains(
         {
           type: "character",
@@ -145,7 +145,7 @@ suite("generalizedRangeContains", () => {
       ),
       true,
     );
-    assert.strictEqual(
+    assert.equal(
       generalizedRangeContains(
         {
           type: "character",

packages/lib-common/src/types/generalizedRangeTouches.test.ts

@@ -1,4 +1,4 @@
-import assert from "assert";
+import * as assert from "node:assert/strict";
 import type { GeneralizedRange } from "./GeneralizedRange";
 import { generalizedRangeTouches } from "./GeneralizedRange";
 import { Position } from "./Position";
@@ -136,6 +136,6 @@ function testRangePair(
   b: GeneralizedRange,
   expected: boolean,
 ) {
-  assert.strictEqual(generalizedRangeTouches(a, b), expected);
-  assert.strictEqual(generalizedRangeTouches(b, a), expected);
+  assert.equal(generalizedRangeTouches(a, b), expected);
+  assert.equal(generalizedRangeTouches(b, a), expected);
 }

packages/lib-common/src/types/isGeneralizedRangeEqual.test.ts

@@ -1,10 +1,10 @@
-import assert from "assert";
+import * as assert from "node:assert/strict";
 import { isGeneralizedRangeEqual } from "./GeneralizedRange";
 import { Position } from "./Position";
 
 suite("isGeneralizedRangeEqual", () => {
   test("character", () => {
-    assert.strictEqual(
+    assert.equal(
       isGeneralizedRangeEqual(
         {
           type: "character",
@@ -19,7 +19,7 @@ suite("isGeneralizedRangeEqual", () => {
       ),
       true,
     );
-    assert.strictEqual(
+    assert.equal(
       isGeneralizedRangeEqual(
         {
           type: "character",
@@ -34,7 +34,7 @@ suite("isGeneralizedRangeEqual", () => {
       ),
       false,
     );
-    assert.strictEqual(
+    assert.equal(
       isGeneralizedRangeEqual(
         {
           type: "character",
@@ -49,7 +49,7 @@ suite("isGeneralizedRangeEqual", () => {
       ),
       false,
     );
-    assert.strictEqual(
+    assert.equal(
       isGeneralizedRangeEqual(
         {
           type: "character",
@@ -67,21 +67,21 @@ suite("isGeneralizedRangeEqual", () => {
   });
 
   test("line", () => {
-    assert.strictEqual(
+    assert.equal(
       isGeneralizedRangeEqual(
         { type: "line", start: 0, end: 0 },
         { type: "line", start: 0, end: 0 },
       ),
       true,
     );
-    assert.strictEqual(
+    assert.equal(
       isGeneralizedRangeEqual(
         { type: "line", start: 0, end: 0 },
         { type: "line", start: 0, end: 1 },
       ),
       false,
     );
-    assert.strictEqual(
+    assert.equal(
       isGeneralizedRangeEqual(
         { type: "line", start: 0, end: 0 },
         { type: "line", start: 1, end: 0 },
@@ -91,7 +91,7 @@ suite("isGeneralizedRangeEqual", () => {
   });
 
   test("mixed", () => {
-    assert.strictEqual(
+    assert.equal(
       isGeneralizedRangeEqual(
         {
           type: "character",
@@ -102,7 +102,7 @@ suite("isGeneralizedRangeEqual", () => {
       ),
       false,
     );
-    assert.strictEqual(
+    assert.equal(
       isGeneralizedRangeEqual(
         { type: "line", start: 0, end: 0 },
         {

packages/lib-common/src/types/position.test.ts

@@ -1,4 +1,4 @@
-import * as assert from "assert";
+import * as assert from "node:assert/strict";
 import { Position } from "./Position";
 
 suite("Position", () => {