Add trigger broadcast method DEV-733#100
Open
jeremygottfried wants to merge 3 commits intocustomerio:mainfrom
Open
Add trigger broadcast method DEV-733#100jeremygottfried wants to merge 3 commits intocustomerio:mainfrom
jeremygottfried wants to merge 3 commits intocustomerio:mainfrom
Conversation
|
It would be great to merge this PR and release. We're using this code on production as well, but we had to depend on our fork for this. Is there anything we can help with here to get this merged? |
|
Maybe @richdawe-cio can help? It seems like he's been actively maintaining the gem recently |
Contributor
|
Thanks for opening this PR, and providing this feature to other folks. I'm just going to close and re-open it, so the latest version of the GitHub Actions are run on the PR. @theycallmeswift I'm going to talk with people internally to see if we can integrate this into the client library. |
|
@richdawe-cio any update on this? |
|
I'd also find this helpful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At MLH, we extended the customerio-ruby gem to add a method for the trigger broadcast API, aka
/v1/campaigns/#{broadcast_id}/triggersThis feature has been very helpful for us, and we'd love to contribute to the base gem so everyone can use it.
Here's an example demonstrating how our code works: