Skip to content

Midi + Jupyter instruments #1889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mscuthbert merged 3 commits into from
May 12, 2026
Merged

Midi + Jupyter instruments #1889

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
37f6220
update midi in Jupyter
mscuthbert May 11, 2026
2cfd517
dist things discovered while releasing 9.9.2
mscuthbert May 12, 2026
d28a134
Fix 2 corpus files with incorrect instruments
mscuthbert May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dist/dist.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,12 +71,12 @@
Don't forget the "v" in the release tag.
Sanity check that the correct commit was tagged: git log

17. Push tags: git push --tags
17. Push that tag: git push origin vX.Y.Z

18. Create a new release on GitHub (using the tag just created) and upload the
non-wheel files created here and docs.

Drag in this order: .tar.gz, -docs.zip, no-corpus.tar.gz
Drag in this order: .tar.gz (wait to finish), -docs.zip (wait), no-corpus.tar.gz

Finish this before doing the next step, even though it looks like it could be done in parallel.

Expand Down
82 changes: 48 additions & 34 deletions documentation/source/usersGuide/usersGuide_02_notes.ipynb
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion documentation/source/usersGuide/usersGuide_22_graphing.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1230,7 +1230,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.13.9"
"version": "3.14.2"
}
},
"nbformat": 4,
Expand Down
4 changes: 2 additions & 2 deletions documentation/source/usersGuide/usersGuide_32_articulations.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -598,9 +598,9 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.11.2"
"version": "3.14.2"
}
},
"nbformat": 4,
"nbformat_minor": 2
"nbformat_minor": 4
}
297 changes: 297 additions & 0 deletions documentation/source/usersGuide/usersGuide_34_instruments.ipynb
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions documentation/source/usersGuide/usersGuide_99_Table_of_Contents.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
"31.\t:ref:`Clefs, Ties, and Beams <usersGuide_31_clefs>`\n",
"32. :ref:`Articulations <usersGuide_32_articulations>`\n",
"33. Expressions and Ornaments (incomplete)\n",
"34. Instruments (incomplete)\n",
"34. :ref:`Instruments <usersGuide_34_instruments>` (incomplete)\n",
"35.\tChord Symbols (incomplete)\n",
"36.\tBars and Repeats (incomplete)\n",
"37. Clients and Weak references (incomplete)\n",
Expand Down Expand Up @@ -111,9 +111,9 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.11.2"
"version": "3.14.2"
}
},
"nbformat": 4,
"nbformat_minor": 1
"nbformat_minor": 4
}
Binary file modified music21/corpus/liliuokalani/aloha_oe.mxl
View file
Open in desktop
Binary file not shown.
Binary file modified music21/corpus/weber/concertino_clarinet.mxl
View file
Open in desktop
Binary file not shown.
2 changes: 2 additions & 0 deletions music21/ipython21/converters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,7 @@ def displayMusic21jMIDI(
fmt,
subformats=subformats,
addStartDelay=True,
**keywords,
)

with open(fp, 'rb') as f:
Expand All @@ -159,6 +160,7 @@ def displayMusic21jMIDI(
display(HTML('''
<div id="''' + outputId + '''"></div>
<link rel="stylesheet" href="https://cuthbertLab.github.io/music21j/css/m21.css">
<link rel="stylesheet" href="https://cuthbertLab.github.io/music21j/css/midiPlayer.css">
''' + load_require_script + '''
<script>
function ''' + outputId + '''_play() {
Expand Down
Loading