Fix install-from-content failing when root-directory doesn't exist#12
Merged
Conversation
When root-directory points to a not-yet-cloned path, call-process fails with "No such file or directory" because default-directory must exist. Add make-directory before the pipeline runs so the CWD is created first. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--install-from-contentcrashes with "No such file or directory" when the spec'sroot-directorypoints to a path that hasn't been created yet (e.g. a not-yet-cloned repo directory)(make-directory default-directory t)before the install pipeline runs, so the CWD is guaranteed to existroot-directoryis created before pipeline stages executeTest plan
make test— all 105 specs passC-c C-con a src block whoseroot-directorydoesn't exist yet — should clone successfully🤖 Generated with Claude Code