View only wallet stuff mainly #1017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sneurlax
requested changes
Nov 14, 2024
Member
There was a problem hiding this comment.
edit: defaultSeedPhraseLength is 14, so this feedback is invalid:
This line https://github.com/cypherstack/stack_wallet/pull/1017/files/49b0b7c0bf2a775fef41aebcd1cd6f70067bb751#diff-725f7b92c3c085b20b03035871c1e51326a77feec2517b2d5a8f6347826f8a7cR95 can be changed to 14, 16, 25 for Wownero, but that's ultimately a design/compatibility choice, so this request for changes can also be accepted as an approval if we just don't want to support 14 word seeds (I think they're dumb, but on the other hand Wowlet uses them, so ¯_(ツ)_/¯)
sneurlax
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some bug fixes as well