Tighten TypeScript safety rules and resolve lint violations#109
Conversation
…rrides This commit strengthens the static analysis posture of the repository by: - Enabling unsafe TypeScript rules (`no-unsafe-assignment`, `no-unsafe-member-access`, `no-unsafe-argument`, `no-unsafe-call`, `no-unsafe-return`) for all source files. - Raising `@typescript-eslint/no-explicit-any` from 'warn' to 'error' for production source code. - Implementing targeted ESLint overrides for tests, scripts, and configuration files to maintain flexibility where strictness is not required. - Refactoring `apps/worker` database client to use generic return types, significantly improving type safety at the data boundary. - Improving type definitions and assertions across `apps/web` and `apps/worker` to resolve violations of the new rules. - Ensuring `pnpm verify` (lint, typecheck, tests, build, e2e) passes across the entire monorepo. Co-authored-by: d-oit <6849456+d-oit@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
…rrides This commit strengthens the static analysis posture of the repository by: - Enabling unsafe TypeScript rules (`no-unsafe-assignment`, `no-unsafe-member-access`, `no-unsafe-argument`, `no-unsafe-call`, `no-unsafe-return`) for all source files. - Raising `@typescript-eslint/no-explicit-any` from 'warn' to 'error' for production source code. - Implementing targeted ESLint overrides for tests, scripts, and configuration files to maintain flexibility where strictness is not required. - Refactoring `apps/worker` database client to use generic return types, significantly improving type safety at the data boundary. - Improving type definitions and assertions across `apps/web` and `apps/worker` to resolve violations of the new rules. - Ensuring `pnpm verify` (lint, typecheck, tests, build, e2e) passes across the entire monorepo. - Fixing CI failure in `smoke-e2e` job by pinning to Chromium and aligning Node.js versions. Co-authored-by: d-oit <6849456+d-oit@users.noreply.github.com>
1 participant
Tightened TypeScript safety rules in ESLint and refactored the codebase to resolve violations. Key changes include enabling unsafe rules for source files, elevating any-usage to an error, and improving the typing of the worker's database client and various web/worker application boundaries.
Fixes #100
PR created automatically by Jules for task 11996114302110942353 started by @d-oit