You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Enabled type-aware ESLint rules and applied recommended configs for React and accessibility. Updated eslint.config.js to use recommendedTypeChecked and configured parserOptions to use the project's tsconfig.json. Applied eslint-plugin-react and eslint-plugin-jsx-a11y recommended flat configs. Downgraded several new rules to warn to allow for incremental fixing of existing violations, and added a lint:strict script to package.json for full enforcement. Fixed associated type errors in src/db/client.ts and src/lib/search.ts.
… configs
Enable typescript-eslint/recommendedTypeChecked, eslint-plugin-react recommended configs, and eslint-plugin-jsx-a11y recommended configs.
Adjusted parserOptions to support type information.
Downgraded several new rules to warnings to allow for incremental fixing of existing technical debt.
Updated package.json with a new lint:strict script.
Fixed type regressions in src/db/client.ts and src/lib/search.ts.
Co-authored-by: d-oit <6849456+d-oit@users.noreply.github.com>
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.
When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.
I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!
For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!
We reviewed changes in 47267ff...54cdab6 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.
Some issues found as part of this review are outside of the diff in this pull request and aren't shown in the inline review comments due to GitHub's API limitations. You can see those issues on the DeepSource dashboard.
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
- Enable typescript-eslint/recommendedTypeChecked
- Apply recommended flat configs for React and jsx-a11y
- Configure parserOptions for project-aware linting
- Downgrade new rules to warnings for incremental fixing
- Add lint:strict script for zero-warning enforcement
- Fix type regressions in src/db/client.ts and src/lib/search.ts
- Resolve unescaped entities and floating promise warnings
Co-authored-by: d-oit <6849456+d-oit@users.noreply.github.com>
The reason will be displayed to describe this comment to others. Learn more.
Expected 'undefined' and instead saw 'void'
The void operator takes an operand and returns undefined. It can be used to ignore the value produced by an expression. However, this can lead to code that is difficult to understand and maintain. Historically, the void operator was used to get a "pure" undefined value, as the undefined variable was mutable prior to ES5.
The reason will be displayed to describe this comment to others. Learn more.
' can be escaped with '
The issue is raised because of missing or unescaped JSX escape characters. These characters would be injected as a text node in JSX statements, which might not be intentional. These won't throw any syntax or runtime errors, but the rendered output will not be the same as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![deepsource-io[bot]](https://avatars.githubusercontent.com/in/16372?s=60&v=4){kind=small}
Enabled type-aware ESLint rules and applied recommended configs for React and accessibility. Updated
eslint.config.jsto userecommendedTypeCheckedand configuredparserOptionsto use the project'stsconfig.json. Appliedeslint-plugin-reactandeslint-plugin-jsx-a11yrecommended flat configs. Downgraded several new rules towarnto allow for incremental fixing of existing violations, and added alint:strictscript topackage.jsonfor full enforcement. Fixed associated type errors insrc/db/client.tsandsrc/lib/search.ts.Fixes #95
PR created automatically by Jules for task 1828195003545706842 started by @d-oit