Split TypeScript configs for app, tests, and Node-side tooling#103
Split TypeScript configs for app, tests, and Node-side tooling#103
Conversation
- Extracted shared compiler options into `tsconfig.base.json`. - Created specialized configurations: `tsconfig.app.json`, `tsconfig.node.json`, and `tsconfig.test.json`. - Refactored the root `tsconfig.json` to use TypeScript Project References. - Updated `eslint.config.js` to use the new project-specific configurations for type-aware linting. - Enabled linting for `cli/` and configuration files by removing them from ignores and assigning them to `tsconfig.node.json`. - Updated `package.json` scripts: `build` now uses `tsconfig.app.json` for type checking, and `typecheck` uses `tsc -b` to check the entire project. - Verified changes with `npm run build`, `npm run typecheck`, `npm run lint`, and both unit and E2E tests. Co-authored-by: d-oit <6849456+d-oit@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
 |
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| JavaScript |  |
May 4, 2026 5:56p.m. | Review ↗ |
| Python | |
May 4, 2026 5:56p.m. | Review ↗ |
| Shell | |
May 4, 2026 5:56p.m. | Review ↗ |
| SQL | |
May 4, 2026 5:56p.m. | Review ↗ |
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
- Extracted shared compiler options into `tsconfig.base.json`. - Created specialized configurations: `tsconfig.app.json`, `tsconfig.node.json`, and `tsconfig.test.json`. - Refactored the root `tsconfig.json` to use TypeScript Project References. - Updated `eslint.config.js` to use the new project-specific configurations for type-aware linting. - Enabled linting for `cli/` and configuration files by removing them from ignores and assigning them to `tsconfig.node.json`. - Fixed a type error in `vitest.config.ts` where coverage thresholds were incorrectly nested. - Updated `package.json` scripts: `build` now uses `tsconfig.app.json` for type checking, and `typecheck` uses `tsc -b` to check the entire project. - Verified changes with `npm run build`, `npm run typecheck`, `npm run lint`, and both unit and E2E tests. Co-authored-by: d-oit <6849456+d-oit@users.noreply.github.com>
1 participant
Split the monolithic
tsconfig.jsoninto specialized configurations for the browser application, testing code, and Node-side tooling (CLI, scripts, and configs). This separation ensures that each execution context uses appropriate compiler settings and types, reducing incidental coupling and making type errors more meaningful.The root
tsconfig.jsonnow serves as a project orchestrator using Project References. ESLint has been updated to support these multiple projects, enabling type-aware linting for previously ignored areas like thecli/directory.Build and typecheck scripts were updated to align with the new structure. All verification steps (build, lint, tests) were successfully executed to ensure no regressions were introduced.
Fixes #98
PR created automatically by Jules for task 1520440758500423346 started by @d-oit