refactor: remove projectedValue when non-DEBUG builds

[ElonPark]

Background (Required)

• Compiler errors are better than fatalError

Changes

• refactor: remove projectedValue when non-DEBUG builds

Testing Methods

• swift test

Review Notes

• x

Summary by CodeRabbit

• Refactor

  • Reformatted several properties for improved code clarity without changing functionality.
  • Simplified conditional compilation for certain properties, removing runtime errors in non-DEBUG builds.

• Bug Fixes

  • Eliminated potential runtime crashes in non-DEBUG builds by removing error-triggering code paths for some properties.

[coderabbitai]

📝 Walkthrough

Walkthrough

This update standardizes the formatting of the projectedValue computed properties within several property wrappers, primarily under #if DEBUG compilation conditions. Additionally, it removes the projectedValue: Never fallback and associated fatalError implementations from non-DEBUG builds in various polymorphic codable wrappers, ensuring these properties are only accessible in DEBUG builds.

Changes

Cohort / File(s)	Change Summary
Formatting: projectedValue in BetterCodable wrappers Sources/KarrotCodableKit/BetterCodable/DataValue/DataValue.swift, .../DateValue/DateValue.swift, .../DateValue/OptionalDateValue.swift, .../Defaults/DefaultCodable.swift, .../LossyValue/LossyArray.swift	Reformatted the projectedValue property from single-line to multi-line syntax under #if DEBUG, with no change in logic or behavior.
Formatting: projectedValue in PolymorphicCodable wrappers Sources/KarrotCodableKit/PolymorphicCodable/PolymorphicValue.swift	Reformatted the projectedValue property from single-line to multi-line syntax under #if DEBUG, maintaining identical logic.
Removal of Non-DEBUG fatalError projectedValue Sources/KarrotCodableKit/PolymorphicCodable/DefaultEmptyPolymorphicArrayValue.swift, .../LossyOptionalPolymorphicValue.swift, .../OptionalPolymorphicValue.swift, .../PolymorphicArrayValue.swift, .../PolymorphicLossyArrayValue.swift	Removed the public var projectedValue: Never with fatalError from non-DEBUG builds, so projectedValue is now only present in DEBUG builds and absent otherwise.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

---

Constructive Feedback & Suggestions:

• The consistent formatting of projectedValue improves readability, but consider automating such style changes with a linter or formatter to reduce manual effort.
• Removing the fatalError fallbacks in non-DEBUG builds is a positive step for safety; however, ensure all usages of projectedValue are guarded by DEBUG checks or tests to prevent accidental access in production.
• For future maintainability, document the DEBUG-only nature of these properties, either in comments or documentation, to help new contributors understand their intended usage and limitations.

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

---

📜 Recent review details

Configuration used: .coderabbit.yml
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3156bf0 and f0d2570.

📒 Files selected for processing (11)

• Sources/KarrotCodableKit/BetterCodable/DataValue/DataValue.swift (1 hunks)
• Sources/KarrotCodableKit/BetterCodable/DateValue/DateValue.swift (1 hunks)
• Sources/KarrotCodableKit/BetterCodable/DateValue/OptionalDateValue.swift (1 hunks)
• Sources/KarrotCodableKit/BetterCodable/Defaults/DefaultCodable.swift (1 hunks)
• Sources/KarrotCodableKit/BetterCodable/LossyValue/LossyArray.swift (1 hunks)
• Sources/KarrotCodableKit/PolymorphicCodable/DefaultEmptyPolymorphicArrayValue.swift (0 hunks)
• Sources/KarrotCodableKit/PolymorphicCodable/LossyOptionalPolymorphicValue.swift (0 hunks)
• Sources/KarrotCodableKit/PolymorphicCodable/OptionalPolymorphicValue.swift (0 hunks)
• Sources/KarrotCodableKit/PolymorphicCodable/PolymorphicArrayValue.swift (0 hunks)
• Sources/KarrotCodableKit/PolymorphicCodable/PolymorphicLossyArrayValue.swift (0 hunks)
• Sources/KarrotCodableKit/PolymorphicCodable/PolymorphicValue.swift (1 hunks)

💤 Files with no reviewable changes (5)

• Sources/KarrotCodableKit/PolymorphicCodable/LossyOptionalPolymorphicValue.swift
• Sources/KarrotCodableKit/PolymorphicCodable/PolymorphicLossyArrayValue.swift
• Sources/KarrotCodableKit/PolymorphicCodable/OptionalPolymorphicValue.swift
• Sources/KarrotCodableKit/PolymorphicCodable/PolymorphicArrayValue.swift
• Sources/KarrotCodableKit/PolymorphicCodable/DefaultEmptyPolymorphicArrayValue.swift

🧰 Additional context used

📓 Path-based instructions (1)

Sources/KarrotCodableKit/**

⚙️ CodeRabbit Configuration File

Sources/KarrotCodableKit/**: You are a senior Swift/iOS engineer reviewing runtime library code for KarrotCodableKit, a comprehensive Codable extension framework.

1. Codable Performance [HIGH]

• Check encoding/decoding efficiency and memory usage
• Verify proper handling of large JSON structures
• Assess polymorphic type resolution performance
• Review property wrapper overhead and optimization

2. Type Safety & Polymorphism [HIGH]

• Validate PolymorphicCodable identifier-based type resolution
• Check AnyCodable type erasure implementation for edge cases
• Verify UnnestedPolymorphic macro integration with runtime components
• Assess error handling in polymorphic decoding scenarios

3. API Design [HIGH]

• Evaluate public interface consistency across modules
• Check property wrapper ergonomics (@DefaultFalse, @DATEvalue, etc.)
• Verify protocol design follows Swift API guidelines
• Assess extensibility for new Codable patterns

4. BetterCodable Integration [MEDIUM]

• Review property wrapper implementations for common patterns
• Check date strategy implementations (ISO8601, RFC3339, etc.)
• Verify default value and lossy conversion handling
• Assess data encoding strategies (Base64, etc.)

5. Error Handling [MEDIUM]

• Verify comprehensive DecodingError and EncodingError usage
• Check PolymorphicCodableError provides sufficient context
• Assess graceful fallback handling in polymorphic scenarios

Review Focus

• Prioritize runtime correctness and performance over style
• Focus on real-world JSON processing scenarios
• Mark comments with priority: [HIGH], [MEDIUM], or [LOW]

Files:

• Sources/KarrotCodableKit/BetterCodable/DateValue/DateValue.swift
• Sources/KarrotCodableKit/PolymorphicCodable/PolymorphicValue.swift
• Sources/KarrotCodableKit/BetterCodable/DataValue/DataValue.swift
• Sources/KarrotCodableKit/BetterCodable/DateValue/OptionalDateValue.swift
• Sources/KarrotCodableKit/BetterCodable/Defaults/DefaultCodable.swift
• Sources/KarrotCodableKit/BetterCodable/LossyValue/LossyArray.swift

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: Check Macro Compatibility
• GitHub Check: Build and Test (16.4, release)

🔇 Additional comments (6)

Sources/KarrotCodableKit/PolymorphicCodable/PolymorphicValue.swift (1)

41-43: Formatting improvement enhances readability and consistency.

The multi-line format for the projectedValue computed property improves code readability and aligns with the formatting pattern applied consistently across all property wrappers in this PR. The DEBUG-only availability supports the architectural goal of preventing runtime fatal errors in release builds.

Sources/KarrotCodableKit/BetterCodable/Defaults/DefaultCodable.swift (1)

52-54: Consistent formatting improvement across property wrappers.

The reformatted projectedValue property maintains identical functionality while improving readability. This change is part of the systematic formatting standardization across all property wrappers in the codebase.

Sources/KarrotCodableKit/BetterCodable/DateValue/DateValue.swift (1)

41-43: Formatting standardization maintains consistency.

The multi-line format for projectedValue follows the same pattern applied across all property wrappers, ensuring consistent code style throughout the BetterCodable module.

Sources/KarrotCodableKit/BetterCodable/LossyValue/LossyArray.swift (1)

32-34: Array-specific projected value type with consistent formatting.

The formatting change follows the established pattern while correctly using ResilientArrayProjectedValue<T> for array-based property wrappers. This maintains type safety while achieving formatting consistency.

Sources/KarrotCodableKit/BetterCodable/DataValue/DataValue.swift (1)

41-43: Completes the systematic formatting standardization.

This final formatting change completes the consistent standardization of projectedValue properties across all property wrappers in the KarrotCodableKit. The systematic approach demonstrates excellent code maintenance practices and supports the PR's architectural goals.

Sources/KarrotCodableKit/BetterCodable/DateValue/OptionalDateValue.swift (1)

41-45: Formatting-only change looks good, but please double-check RELEASE builds compile cleanly

The switch to a multi-line computed property under #if DEBUG is harmless and keeps the API surface unchanged for debug builds, so no objections here.
As the overarching goal of the PR is to guarantee that projectedValue disappears from non-DEBUG targets, make sure every target that’s compiled with -c release (or in Xcode’s “Release” configuration) still builds without any stray projectedValue references—especially in unit tests or sample apps that might be compiled in release mode for benchmarking.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch feature/elon/refactor-projectedValue

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[jinsu3758]

LGTM 👍