Skip to content

Conversation

@pnvasanth
Copy link

@pnvasanth pnvasanth commented Jan 20, 2026

Summary

  • Migrate TIME-ranked feed from V1 (TypeORM query builder) to V2 (feed service)
  • Add time feed generator with same config as popular but with order_by: Date
  • Feed service handles deduplication and sorting server-side

Test plan

  • Existing TIME feed tests pass
  • Feed resolvers use V2 path when version >= 2 && ranking === TIME

🤖 Generated with Claude Code

@pnvasanth pnvasanth requested review from a team and capJavert as code owners January 20, 2026 11:31
@pnvasanth pnvasanth self-assigned this Jan 20, 2026
@pulumi
Copy link

pulumi bot commented Jan 20, 2026

🍹 The Update (preview) for dailydotdev/api/prod (at 56a0092) was successful.

Resource Changes

    Name                                                   Type                           Operation
~   vpc-native-personalized-digest-deployment              kubernetes:apps/v1:Deployment  update
-   vpc-native-api-db-migration-62f6ca9c                   kubernetes:batch/v1:Job        delete
~   vpc-native-update-source-tag-view-cron                 kubernetes:batch/v1:CronJob    update
~   vpc-native-update-source-public-threshold-cron         kubernetes:batch/v1:CronJob    update
~   vpc-native-deployment                                  kubernetes:apps/v1:Deployment  update
~   vpc-native-check-analytics-report-cron                 kubernetes:batch/v1:CronJob    update
-   vpc-native-api-clickhouse-migration-62f6ca9c           kubernetes:batch/v1:Job        delete
+   vpc-native-api-db-migration-2dbcadca                   kubernetes:batch/v1:Job        create
~   vpc-native-personalized-digest-cron                    kubernetes:batch/v1:CronJob    update
~   vpc-native-update-tags-str-cron                        kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-zombie-images-cron                    kubernetes:batch/v1:CronJob    update
~   vpc-native-sync-subscription-with-cio-cron             kubernetes:batch/v1:CronJob    update
~   vpc-native-validate-active-users-cron                  kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-stale-user-transactions-cron          kubernetes:batch/v1:CronJob    update
~   vpc-native-temporal-deployment                         kubernetes:apps/v1:Deployment  update
~   vpc-native-post-analytics-history-day-clickhouse-cron  kubernetes:batch/v1:CronJob    update
~   vpc-native-update-tag-recommendations-cron             kubernetes:batch/v1:CronJob    update
~   vpc-native-generic-referral-reminder-cron              kubernetes:batch/v1:CronJob    update
~   vpc-native-hourly-notification-cron                    kubernetes:batch/v1:CronJob    update
~   vpc-native-update-views-cron                           kubernetes:batch/v1:CronJob    update
~   vpc-native-post-analytics-clickhouse-cron              kubernetes:batch/v1:CronJob    update
~   vpc-native-private-deployment                          kubernetes:apps/v1:Deployment  update
~   vpc-native-clean-zombie-opportunities-cron             kubernetes:batch/v1:CronJob    update
~   vpc-native-generate-search-invites-cron                kubernetes:batch/v1:CronJob    update
~   vpc-native-user-profile-updated-sync-cron              kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-gifted-plus-cron                      kubernetes:batch/v1:CronJob    update
~   vpc-native-ws-deployment                               kubernetes:apps/v1:Deployment  update
+   vpc-native-api-clickhouse-migration-2dbcadca           kubernetes:batch/v1:Job        create
~   vpc-native-update-trending-cron                        kubernetes:batch/v1:CronJob    update
~   vpc-native-update-highlighted-views-cron               kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-zombie-user-companies-cron            kubernetes:batch/v1:CronJob    update
~   vpc-native-bg-deployment                               kubernetes:apps/v1:Deployment  update
~   vpc-native-update-current-streak-cron                  kubernetes:batch/v1:CronJob    update
~   vpc-native-daily-digest-cron                           kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-zombie-users-cron                     kubernetes:batch/v1:CronJob    update
~   vpc-native-calculate-top-readers-cron                  kubernetes:batch/v1:CronJob    update

@pnvasanth pnvasanth changed the title feat(feed): deduplicate share posts in TIME-ranked feed feat(feed): migrate TIME-ranked feed to V2 Jan 20, 2026
@pnvasanth pnvasanth force-pushed the myfeed-order-time-dedup branch from 9a482b2 to 3bd6b92 Compare January 20, 2026 12:58
pnvasanth and others added 2 commits January 20, 2026 19:19
When a SharePost and its original post both appear in the TIME feed,
only show the original. Shares are shown when their original is
banned, private, or hidden from feed.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@pnvasanth pnvasanth force-pushed the myfeed-order-time-dedup branch from 3bd6b92 to c744ac5 Compare January 20, 2026 13:50
Use the feed service for TIME ranking instead of TypeORM query builder.
Adds a 'time' feed generator with same config as 'popular' but with
order_by set to Date.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@pnvasanth pnvasanth force-pushed the myfeed-order-time-dedup branch from c744ac5 to 56a0092 Compare January 20, 2026 13:55
Copy link
Member

@idoshamun idoshamun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. @capJavert wdyt?

Copy link
Contributor

@capJavert capJavert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok yes

@capJavert
Copy link
Contributor

capJavert commented Jan 20, 2026

@pnvasanth maybe add some tests if possible, can add it per query in __tests__/feeds.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants