fix: feedByIds to return share posts from user sources #3461
+47
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
…icThreshold filter Co-authored-by: omBratteng <1681525+omBratteng@users.noreply.github.com>
…t types Co-authored-by: omBratteng <1681525+omBratteng@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix feedByIds to return share posts from SourceUser
Fix feedByIds to return share posts from user sources
Jan 20, 2026
omBratteng
changed the title
omBratteng
approved these changes
Jan 20, 2026
omBratteng
reviewed
Jan 20, 2026
| (ctx, args, { limit, offset }, builder) => | ||
| builder.limit(limit).offset(offset), | ||
| { | ||
| removeNonPublicThresholdSquads: false, |
Member
|
leaving as is, and let filter them out in briefing instead |
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
feedByIdswas filtering out share posts fromSourceType.Userdue to filtering out non-publich threshold sources.removeNonPublicThresholdSquads: falsesince explicit ID queries should bypass source visibility rulesExample link
https://app.daily.dev/feed-by-ids?id=088gbJeif&id=yqIOzOa7R
ENG-262
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.