-
Notifications
You must be signed in to change notification settings - Fork 113
feat: anon login claim opportunities #3463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
capJavert
wants to merge
3
commits into
main
Choose a base branch
from
anon-login-claim-opportunity
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🍹 The Update (preview) for dailydotdev/api/prod (at 0c4c44a) was successful. Resource Changes Name Type Operation
~ vpc-native-update-trending-cron kubernetes:batch/v1:CronJob update
~ vpc-native-update-tag-recommendations-cron kubernetes:batch/v1:CronJob update
- vpc-native-api-clickhouse-migration-6f39e1b2 kubernetes:batch/v1:Job delete
~ vpc-native-clean-zombie-user-companies-cron kubernetes:batch/v1:CronJob update
~ vpc-native-user-profile-updated-sync-cron kubernetes:batch/v1:CronJob update
~ vpc-native-personalized-digest-cron kubernetes:batch/v1:CronJob update
~ vpc-native-clean-zombie-users-cron kubernetes:batch/v1:CronJob update
~ vpc-native-clean-zombie-images-cron kubernetes:batch/v1:CronJob update
~ vpc-native-post-analytics-history-day-clickhouse-cron kubernetes:batch/v1:CronJob update
+ vpc-native-api-clickhouse-migration-390948aa kubernetes:batch/v1:Job create
~ vpc-native-update-highlighted-views-cron kubernetes:batch/v1:CronJob update
~ vpc-native-daily-digest-cron kubernetes:batch/v1:CronJob update
~ vpc-native-ws-deployment kubernetes:apps/v1:Deployment update
~ vpc-native-check-analytics-report-cron kubernetes:batch/v1:CronJob update
~ vpc-native-sync-subscription-with-cio-cron kubernetes:batch/v1:CronJob update
~ vpc-native-update-source-tag-view-cron kubernetes:batch/v1:CronJob update
~ vpc-native-update-current-streak-cron kubernetes:batch/v1:CronJob update
~ vpc-native-validate-active-users-cron kubernetes:batch/v1:CronJob update
~ vpc-native-generate-search-invites-cron kubernetes:batch/v1:CronJob update
~ vpc-native-private-deployment kubernetes:apps/v1:Deployment update
~ vpc-native-clean-gifted-plus-cron kubernetes:batch/v1:CronJob update
~ vpc-native-clean-zombie-opportunities-cron kubernetes:batch/v1:CronJob update
~ vpc-native-hourly-notification-cron kubernetes:batch/v1:CronJob update
~ vpc-native-bg-deployment kubernetes:apps/v1:Deployment update
+ vpc-native-api-db-migration-390948aa kubernetes:batch/v1:Job create
~ vpc-native-update-tags-str-cron kubernetes:batch/v1:CronJob update
~ vpc-native-personalized-digest-deployment kubernetes:apps/v1:Deployment update
~ vpc-native-temporal-deployment kubernetes:apps/v1:Deployment update
~ vpc-native-generic-referral-reminder-cron kubernetes:batch/v1:CronJob update
~ vpc-native-update-source-public-threshold-cron kubernetes:batch/v1:CronJob update
~ vpc-native-calculate-top-readers-cron kubernetes:batch/v1:CronJob update
~ vpc-native-post-analytics-clickhouse-cron kubernetes:batch/v1:CronJob update
- vpc-native-api-db-migration-6f39e1b2 kubernetes:batch/v1:Job delete
~ vpc-native-update-views-cron kubernetes:batch/v1:CronJob update
~ vpc-native-clean-stale-user-transactions-cron kubernetes:batch/v1:CronJob update
~ vpc-native-deployment kubernetes:apps/v1:Deployment update
|
omBratteng
reviewed
Jan 20, 2026
Comment on lines
+1
to
+27
| import { MigrationInterface, QueryRunner } from 'typeorm'; | ||
|
|
||
| export class ClaimableItemIdentifier1768937354866 implements MigrationInterface { | ||
| name = 'ClaimableItemIdentifier1768937354866'; | ||
|
|
||
| public async up(queryRunner: QueryRunner): Promise<void> { | ||
| await queryRunner.query(`DROP INDEX "public"."IDX_claimable_item_email"`); | ||
| await queryRunner.query( | ||
| `ALTER TABLE "claimable_item" RENAME COLUMN "email" TO "identifier"`, | ||
| ); | ||
| await queryRunner.query( | ||
| `CREATE INDEX "IDX_claimable_item_identifier" ON "claimable_item" ("identifier") `, | ||
| ); | ||
| } | ||
|
|
||
| public async down(queryRunner: QueryRunner): Promise<void> { | ||
| await queryRunner.query( | ||
| `DROP INDEX "public"."IDX_claimable_item_identifier"`, | ||
| ); | ||
| await queryRunner.query( | ||
| `ALTER TABLE "claimable_item" RENAME COLUMN "identifier" TO "email"`, | ||
| ); | ||
| await queryRunner.query( | ||
| `CREATE INDEX "IDX_claimable_item_email" ON "claimable_item" ("email") `, | ||
| ); | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| import { MigrationInterface, QueryRunner } from 'typeorm'; | |
| export class ClaimableItemIdentifier1768937354866 implements MigrationInterface { | |
| name = 'ClaimableItemIdentifier1768937354866'; | |
| public async up(queryRunner: QueryRunner): Promise<void> { | |
| await queryRunner.query(`DROP INDEX "public"."IDX_claimable_item_email"`); | |
| await queryRunner.query( | |
| `ALTER TABLE "claimable_item" RENAME COLUMN "email" TO "identifier"`, | |
| ); | |
| await queryRunner.query( | |
| `CREATE INDEX "IDX_claimable_item_identifier" ON "claimable_item" ("identifier") `, | |
| ); | |
| } | |
| public async down(queryRunner: QueryRunner): Promise<void> { | |
| await queryRunner.query( | |
| `DROP INDEX "public"."IDX_claimable_item_identifier"`, | |
| ); | |
| await queryRunner.query( | |
| `ALTER TABLE "claimable_item" RENAME COLUMN "identifier" TO "email"`, | |
| ); | |
| await queryRunner.query( | |
| `CREATE INDEX "IDX_claimable_item_email" ON "claimable_item" ("email") `, | |
| ); | |
| } | |
| } | |
| import { MigrationInterface, QueryRunner } from 'typeorm'; | |
| export class ClaimableItemIdentifier1768937354866 | |
| implements MigrationInterface | |
| { | |
| name = 'ClaimableItemIdentifier1768937354866'; | |
| public async up(queryRunner: QueryRunner): Promise<void> { | |
| await queryRunner.query(/* sql */ ` | |
| DROP INDEX IF EXISTS "public"."IDX_claimable_item_email" | |
| `); | |
| await queryRunner.query(/* sql */ ` | |
| ALTER TABLE "claimable_item" | |
| RENAME COLUMN "email" TO "identifier" | |
| `); | |
| await queryRunner.query(/* sql */ ` | |
| CREATE INDEX IF NOT EXISTS "IDX_claimable_item_identifier" | |
| ON "claimable_item" ("identifier") | |
| `); | |
| } | |
| public async down(queryRunner: QueryRunner): Promise<void> { | |
| await queryRunner.query(/* sql */ ` | |
| DROP INDEX IF EXISTS "public"."IDX_claimable_item_identifier" | |
| `); | |
| await queryRunner.query(/* sql */ ` | |
| ALTER TABLE "claimable_item" | |
| RENAME COLUMN "identifier" TO "email" | |
| `); | |
| await queryRunner.query(/* sql */ ` | |
| CREATE INDEX IF NOT EXISTS "IDX_claimable_item_email" | |
| ON "claimable_item" ("email") | |
| `); | |
| } | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
emailcolumn toidentifier, to make it more generic and reusable