fix: squad member join notification when welcome post is deleted

[Copilot]

When a welcome post is deleted, squad member join notifications link to a non-existent post and suggest users comment on it. Users click the notification and encounter a 404, and the message is misleading.

Changes

Notification generation (src/notifications/generate.ts):

• Check post.deleted flag in squad_member_joined builder and title
• If deleted: use targetSource() to link to squad page and remove comment suggestion from message
• If not deleted: preserve existing behavior (link to post with comment suggestion)

Test coverage (__tests__/notifications/index.ts):

• Added test case verifying squad page link when welcome post is deleted
• Added test assertion for notification title without comment mention

Examples

Notification builder:

squad_member_joined: (builder, ctx) => {
  const baseBuilder = builder
    .icon(NotificationIcon.Bell)
    .referenceSource(ctx.source)
    .avatarSource(ctx.source)
    .avatarManyUsers([ctx.doneBy])
    .uniqueKey(ctx.doneBy.id);

  // Link to squad page if welcome post deleted
  if (ctx.post.deleted) {
    return baseBuilder.targetSource(ctx.source);
  }

  // Otherwise link to post with comment suggestion
  return baseBuilder
    .targetPost(ctx.post)
    .setTargetUrlParameter(/* ... */);
},

Notification title:

squad_member_joined: (ctx) => {
  const baseMessage = `Your squad <b>${ctx.source.name}</b> is growing! Welcome <b>${ctx.doneBy.name}</b> to the squad`;
  // Don't mention commenting when welcome post is deleted
  return ctx.post.deleted
    ? `${baseMessage}.`
    : `${baseMessage} with a comment.`;
},

Original prompt

When someone joins the squad and the welcome post is deleted, update the notification so that it does not link to the welcome page

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ omBratteng
❌ Copilot
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[omBratteng]

@copilot Also update the notification message so that it no longer says anything about a comment when the welcome post is deleted

[Copilot]

@copilot Also update the notification message so that it no longer says anything about a comment when the welcome post is deleted

Updated in d6efa3e. The notification title now conditionally excludes "with a comment" when the welcome post is deleted.