Merged
Conversation
Implement Ruby's safe navigation operator semantics in the type checker: - Add `safe_navigation` flag to NeedsChildKind::MethodCall, MethodCallContext, and MethodCallBox, detected via ruby-prism's `is_safe_navigation()` - Skip nil receiver in process_recv_type() to suppress false "undefined method for NilClass" errors when using `&.` - Add nil to return type in run() only when receiver types actually include nil, preserving type precision for non-nilable receivers (e.g. `str&.upcase` stays `String`, not `String | nil`) This eliminates false positives on `&.` calls, which are pervasive in Rails and modern Ruby codebases. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
dak2
force-pushed
the
add-safe-navigation-operator-support
branch
from
84649bf to
1e02eae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
safe_navigation: boolflag through the call pipeline (NeedsChildKind::MethodCall→MethodCallContext→MethodCallBox) to track&.operator usage&.is usednilto return type only when receiver types actually includenil, preserving type precision for non-nilable receivers (e.g.str&.upcase→String, notString | nil)Test plan
MethodCallBoxwith safe_navigation flag (nil receiver, nilable receiver, non-nil receiver, normal call comparison)test_safe_navigation_basic,test_safe_navigation_undefined_method,test_safe_navigation_nil_receiver,test_safe_navigation_chainsafe_navigation: falseadded to call sites🤖 Generated with Claude Code