fix(installer): surface manage.sh stderr when Pulse install fails#1311
Open
stevetr68 wants to merge 1 commit into
Open
fix(installer): surface manage.sh stderr when Pulse install fails#1311stevetr68 wants to merge 1 commit into
stevetr68 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When Pulse fails to install,
installPulse()reports a generic message and discards thereal cause. It spawns
manage.sh installwith stderr piped, but never reads the pipe:So a real failure inside
manage.sh(missing~/Library/LaunchAgents, ased/launchctlerror, etc.) is swallowed — the installer prints "install command failed" with no detail
and the user is left guessing.
Fix
Accumulate the already-piped stderr and include its tail in the failure message. No new
process behavior, no extra spawn — just stop throwing away output we're already capturing.
Pairs with #1310 — that fixes one common cause of the silent failure; this makes any
remaining cause visible instead of opaque.