Refactor XML namespace handling in BaseXmlModel and add test, resolve…#316
Open
falkben wants to merge 1 commit into
Open
Refactor XML namespace handling in BaseXmlModel and add test, resolve…#316falkben wants to merge 1 commit into
falkben wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #315
Regression was introduced in bb30d8b which replaced a simple inherit-by-reference with an in-place
parent_nsmap.update(nsmap or {}). That mutates the parent class's (and, in issue #315, the module-level shared) nsmap dict.This PR was developed with the assistance of Cursor. I've reviewed and verified the changes.