fix: parse PEP 440 pre-release versions in compat module#318
Open
ericbuehl wants to merge 1 commit into
Open
Conversation
tuple(map(int, pd.__version__.partition('+')[0].split('.'))) raised
ValueError on valid pre-release version strings such as '2.14.0a0' or
'2.14.0.dev0', because int('0a0') fails.
Switch to packaging.version.Version, which handles the full PEP 440
grammar and gives correct ordering semantics for pre-release, dev, and
post-release versions.
packaging is declared as a new dependency. It is already a transitive
dependency in virtually all Python environments (via pip/setuptools),
so the declaration only makes existing reality explicit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tuple(map(int, pd.version.partition('+')[0].split('.'))) raised ValueError on valid pre-release version strings such as '2.14.0a0' or '2.14.0.dev0', because int('0a0') fails.
Switch to packaging.version.Version, which handles the full PEP 440 grammar and gives correct ordering semantics for pre-release, dev, and post-release versions.
packaging is declared as a new dependency. It is already a transitive dependency in virtually all Python environments (via pip/setuptools), so the declaration only makes existing reality explicit.