add 'reserve' variable instead of hard coded gas of 5000 for delegatecall#13
Open
r001 wants to merge 1 commit intodapphub:masterfrom
Open
add 'reserve' variable instead of hard coded gas of 5000 for delegatecall#13r001 wants to merge 1 commit intodapphub:masterfrom
r001 wants to merge 1 commit intodapphub:masterfrom
Conversation
Member
|
To clarify: this is to future proof ds-proxy against gas pricing changes in the EVM. @gbalabasquer @NiklasKunkel want to restate any opinions here? |
Contributor
|
I'd merge this. I hope the gas prices do not change enough to over pass the 5000, otherwise we will be in a trouble. Then I say in a nice thing to have. My only question would be if there is any added value to declare the variable as |
Contributor
|
The 5000 gas is so far over the current actual cost that it should be
immune to future restructuring of gas prices.
…On Sat, Nov 24, 2018 at 8:13 AM Gonzalo Balabasquer < ***@***.***> wrote:
I'd merge this. I hope the gas prices do not change enough to over pass
the 5000, otherwise we will be in a trouble. Then I say in a nice thing to
have. My only question would be if there is any added value to declare the
variable as uint128 instead of uint256.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#13 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABu7vdx48GqXQpvg0FgZ2MtSzSUddbE6ks5uyXAdgaJpZM4Qh-8j>
.
|
Contributor
|
Yeah I guess the 4200 gas gap should be more than enough, however should it hurt somehow to have it manageable? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor update to add variable instead of hard coded gas value in delegatecall.